Skip to content

[MRG] DOC make more obvious that logistic regression is regularized by default #14093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2019

Conversation

NicolasHug
Copy link
Member

closes #14070

ping @amueller

Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should even make it say "which is conventional in machine learning but not in statistics"

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the change. I would only use sphinx directive there.

regularization. Note that regularization is applied by default.
regularization.

**Note that regularization is applied by default**, which is common in machine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the .. note:: directive from sphinx to highlight it better

@glemaitre glemaitre merged commit 62d1112 into scikit-learn:master Jun 24, 2019
@glemaitre
Copy link
Member

I checked the rendering and this is fine. Thanks.

koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add section on regularization to logistic regression docs
5 participants