Skip to content

updated class_weight explanation #14121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

arnaudstiegler
Copy link
Contributor

@arnaudstiegler arnaudstiegler commented Jun 18, 2019

Reference Issues/PRs

Fix #14111

What does this implement/fix? Explain your changes.

Added a comment about class_weight mentioning that it alters loss function for linear models, and splitting criteria for tree-based models

Any other comments?

doc/glossary.rst Outdated
as linear SVM or logistic regression), the class weights will alter the
loss function by weighting the loss of each sample by its class weight.
For tree-based algorithms, the class weights will be used when
calculating the splitting criteria.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reweight the splitting criterion?

Copy link
Member

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from nitpick. Thanks!

@amueller
Copy link
Member

If you're fixing an issue, please say "Fix # issuenumber" in your
Please use "Fix #issueNumber" in your PR description (and you can do it more than once). This way the associated issue gets closed automatically when the PR is merged. For more details, look at this.

@arnaudstiegler
Copy link
Contributor Author

Sorry about that, I added the issue number to the PR description

@adrinjalali adrinjalali merged commit f9f8974 into scikit-learn:master Jun 19, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
* updated class_weight explanation

* glossary_class_weight
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Jul 29, 2019
* updated class_weight explanation

* glossary_class_weight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glossary doesn't say that class_weight modifies loss function
3 participants