Skip to content

TST refactor test for PCA #14138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 26, 2019
Merged

TST refactor test for PCA #14138

merged 13 commits into from
Jun 26, 2019

Conversation

glemaitre
Copy link
Member

To ease implementing the tests in #12319, I am refactoring some of the tests in test_pca.py using pytest parametrization. This can be useful even if #12319 is not merged.

@glemaitre glemaitre changed the title [WIP] MAINT refactor test for PCA [MRG] MAINT refactor test for PCA Jun 21, 2019
@glemaitre
Copy link
Member Author

I would need some warriors here: ping @thomasjpfan @NicolasHug @rth
The diff is big but I did not change the tests. Just parametrization which will ease the inclusion of any new solver.

@rth was it what we were discussing?

rth
rth approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @glemaitre thank you! Will definitely make things easier for the LOBPCG PR.

It's indeed not that easy to review, but I haven't seen any issues. LGTM.

@rth rth mentioned this pull request Jun 21, 2019
Merged
jnothman
jnothman reviewed Jun 23, 2019
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

(Is it time to sweep through the code base with assert replacing assert_equal and assert_greater as we did for assert_true and assert_false? I don't think unit tests are high risk for merge conflicts with PRs.)

@glemaitre glemaitre changed the title [MRG] MAINT refactor test for PCA [MRG] TST refactor test for PCA Jun 24, 2019
rth
rth approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of the above comments were addressed. Merging. Thanks!

@rth rth changed the title [MRG] TST refactor test for PCA TST refactor test for PCA Jun 26, 2019
@rth rth merged commit a1df5c7 into scikit-learn:master Jun 26, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@glemaitre @koenvandevelde
TST refactor test for PCA (scikit-learn#14138)
5c011c3
@ShanDeng123 ShanDeng123 mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

@thomasjpfan thomasjpfan thomasjpfan left review comments

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glemaitre @jnothman @rth @thomasjpfan