Skip to content

DOC fixing the missing fetch upstream in contributing docs #14142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2019
Merged

DOC fixing the missing fetch upstream in contributing docs #14142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion doc/developers/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,10 @@ then submit a "pull request" (PR):

$ git remote add upstream https://github.com/scikit-learn/scikit-learn.git

7. Create a branch to hold your development changes::
7. Fetch the ``upstream`` and then create a branch to hold your development
changes::

$ git fetch upstream
$ git checkout -b my-feature upstream/master

and start making changes. Always use a ``feature`` branch. It's good
Expand Down