Skip to content

MAINT Fix test_fit_csr_matrix failure on master #14171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2019
Merged

MAINT Fix test_fit_csr_matrix failure on master #14171

merged 1 commit into from
Jun 23, 2019

Conversation

rth
Copy link
Member

@rth rth commented Jun 23, 2019

Closes #14168

test_fit_csr_matrix is sometimes failing on Linux py35_conda_openblas likely to the dataset size reduction recently cf #14168 (comment) (and the reduction in n_iter from 1000 (default) to 500).

This increases n_iter back to 750, and increases the relative tolerance from 0.10 to 0.11.

thomasjpfan
thomasjpfan approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 8b002f2 into scikit-learn:master Jun 23, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@rth @koenvandevelde
MAINT Fix test_fit_csr_matrix failure on master (scikit-learn#14171)
f5c6114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_fit_csr_matrix failing on Linux py35_conda_openblas
3 participants
@rth @jnothman @thomasjpfan