-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[MRG] TST Increases tolerance to match float32 resolution #14184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] TST Increases tolerance to match float32 resolution #14184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
How does increasing tolerance improve the ability of the estimators to find
the same solution?
|
For this PR, I was thinking that the different between two 32 bit floats can only be resolve up to Looking at the docs for sparse.linalg.cg the |
So is the proposal to make this change on a conjecture and hope the failure
goes away?
|
I’m going to see if this changes things on the CI for macPython by specifically pulling this branch. |
This pass on travis ci on osx. Here is the diff of the scikit-learn-wheels version that was used to run the travis ci instances. |
Thanks @thomasjpfan |
Reference Issues/PRs
Fixes #13868
Fixes #13876
What does this implement/fix? Explain your changes.
Changes
tol
tonp.finfo(np.float32).resolution
Any other comments?
I suspect that float64 found a better (and different) solution because it can resolve
1e-10
better than float32 can.