Skip to content

DOC make explicit that groups required *Group* splitter #14235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

DOC make explicit that groups required *Group* splitter #14235

merged 1 commit into from
Jul 2, 2019

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jul 2, 2019 •
edited
Loading

closes #11406

Make explicit that the parameter groups requires Group splitter from model_selection.

@glemaitre
Copy link
Member Author

glemaitre commented Jul 2, 2019 •
edited
Loading

ping @rth @amueller @jnothman

amueller
amueller approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jnothman
jnothman approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Our handling of groups is a bit inconsistent with how we handle sample_weight, which will raise an error if passed and not used. We should probably be raising a warning in other splitters when groups is passed.

thomasjpfan
thomasjpfan reviewed Jul 2, 2019
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also place this in the docstring of the *Split classes in sklearn/model_selection/_split.py?

Edit: Lets not.

@thomasjpfan thomasjpfan merged commit e68f6f3 into scikit-learn:master Jul 2, 2019
@jnothman jnothman added this to the 0.20.4 milestone Jul 2, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@glemaitre @koenvandevelde
DOC Make explicit that groups required *Group* splitter (scikit-learn…
4ab6ce3 
…#14235)
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Jul 23, 2019
@glemaitre @jnothman
DOC Make explicit that groups required *Group* splitter (scikit-learn…
3e14f61 
…#14235)
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Jul 23, 2019
@glemaitre @jnothman
DOC Make explicit that groups required *Group* splitter (scikit-learn…
d56d93c 
…#14235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@amueller amueller amueller approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.4
Development

Successfully merging this pull request may close these issues.

cross_val_predict with groups input: is it used?
4 participants
@glemaitre @jnothman @amueller @thomasjpfan