Skip to content

[MRG] Add tree submodule attribute documentation #14339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mepa
Copy link
Contributor

@mepa mepa commented Jul 13, 2019

Reference Issues/PRs

#14312

What does this implement/fix? Explain your changes.

Adds sklearn.tree.tree documentation for the following class, [attributes] combinations:

  • ExtraTreeClassifier, [classes_, max_features_, n_classes_, n_features_, n_outputs_, tree_]
  • ExtraTreeRegressor, [max_features_, n_features_, n_outputs_, tree_]

Any other comments?

Note that the script output shown in #14312 (comment) includes classes_ and n_classes_ for DecisionTreeRegressor and ExtraTreeRegressor. I have not added attribute documentation in those cases since it does not make sense to have these attributes in regression estimators.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mepa

@amueller
Copy link
Member

great, thanks!

@amueller amueller merged commit b4f3d66 into scikit-learn:master Jul 13, 2019
@mepa mepa deleted the 14312-doc-tree-submodule-attributes branch July 13, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants