Replacing np.zeroes by np.empty for Gradient Boosting for better scaling by cores #14380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @SmirnovEgorRu, there seems to be a few unrelated changes though? |
NicolasHug
reviewed
Jul 16, 2019
| shape=(self.n_features, self.max_bins), | ||
| dtype=HISTOGRAM_DTYPE | ||
| ) | ||
|
|
||
| for feature_idx in prange(n_features, schedule='static', nogil=True): | ||
| # for feature_idx in prange(n_features, schedule='static', nogil=True): | ||
| for feature_idx in range(n_features): |
There was a problem hiding this comment.
Why replace prange with range?
| @@ -103,7 +103,9 @@ cdef class HistogramBuilder: | |||
|
|
|||
| def compute_histograms_brute( | |||
| HistogramBuilder self, | |||
| const unsigned int [::1] sample_indices): # IN | |||
| const unsigned int [::1] sample_indices, | |||
| hist_struct [:, ::1] parent): # IN | |||
There was a problem hiding this comment.
I don't fully understand why you need to change the API here.
We have 2 routines to compute histograms:
-
compute_histograms_subtraction, used when we know the histogram of the parent and the sibling of a node (using the subtraction trick) -
compute_histograms_bruteused in all other cases. With that function, we do not need the histogram of the parent.
|
For reference @NicolasHug did a similar PR here: #14392 but unfortunately this does not seem to solve the scalabilty profile. |
|
Closing as a duplicate of #18341 (credited you there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have prepared a PR with replacing np.zeroes to np.empty for performance improvement on multi-core systems.
Original issue: #14306