Skip to content

DOC some attribute documentation #14459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2019
Merged

DOC some attribute documentation #14459

merged 2 commits into from
Jul 25, 2019

Conversation

amueller
Copy link
Member

Some changes from #13385 so we don't duplicate work (and so I don't have to keep fixing merge issues)

@amueller
Copy link
Member Author

mostly by @TomDLT I think?

@jnothman jnothman changed the title some attribute documentation DOC some attribute documentation Jul 24, 2019
@@ -1202,6 +1202,9 @@ class NMF(BaseEstimator, TransformerMixin):
the training data ``X`` and the reconstructed data ``WH`` from
the fitted model.

n_components_ : int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n_components_ is already documented.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants