-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
DOC A few what's new fixes for 0.21.3 #14500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- |Fix| Fixed a bug in :class:`cluster.KMeans` where computation was single | ||
threaded when `n_jobs > 1` or `n_jobs = -1`. | ||
- |Fix| Fixed a bug in :class:`cluster.KMeans` where computation with | ||
`init='random'` was single threaded for `n_jobs > 1` or `n_jobs = -1`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indicating that multi-threading wasn't working in general was a bit vague
@@ -100,6 +107,10 @@ Changelog | |||
- |Fix| Fixed bug in :func:`tree.export_text` when the tree has one feature and | |||
a single feature name is passed in. :pr:`14053` by `Thomas Fan`. | |||
|
|||
- |Fix| Fixed an issue with :func:`plot_tree` where it display | |||
entropy calculations even for `gini` criterion in DecisionTreeClassifiers. | |||
:pr:`13947` by :user:`Frank Hoang <fhoang7>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not part of 0.21.2 as far as I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
|
||
- |Fix| Fix zero division error in :func:`HistGradientBoostingClassifier` and | ||
:func:`HistGradientBoostingRegressor`. | ||
:pr:`14024` by `Nicolas Hug <NicolasHug>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no what's new entry, but I think it's good to have one even if the estimators are experimental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looking good!
Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>
Thanks @jnothman, included your suggestion. This is ready to be merged I think. |
@@ -100,6 +107,10 @@ Changelog | |||
- |Fix| Fixed bug in :func:`tree.export_text` when the tree has one feature and | |||
a single feature name is passed in. :pr:`14053` by `Thomas Fan`. | |||
|
|||
- |Fix| Fixed an issue with :func:`plot_tree` where it display | |||
entropy calculations even for `gini` criterion in DecisionTreeClassifiers. | |||
:pr:`13947` by :user:`Frank Hoang <fhoang7>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
A few what's new fixes for 0.21.3 (#14188)
These should be merged into master, than back-ported to 0.21.X
TODO