Skip to content

Conversation

thomasjpfan
Copy link
Member

This PR updates version of scikit-image to work with 3.5-3.7. scikit-image=0.12.3 is not on conda anymore.

@amueller
Copy link
Member

Do they just remove things from the main channel? That seems pretty bad. Do you think we should open an issue on that?

@thomasjpfan
Copy link
Member Author

thomasjpfan commented Jul 29, 2019

They removed numpy=1.11.0, matplotlib=1.5.1, and scipy=0.17.0.

@grlee77
Copy link
Contributor

grlee77 commented Jul 29, 2019

You may still be able to access the older packages (e.g. pre Sept. 2017) by explicitly adding the "free" channel. It used to be included by default, but they changed that fairly recently.

e.g. conda config --set restore_free_channel true
https://docs.conda.io/projects/conda/en/latest/user-guide/configuration/free-channel.html#using-the-free-channel

The rationale for this decision on Anaconda's end is explained here:
https://www.anaconda.com/why-we-removed-the-free-channel-in-conda-4-7/

@amueller
Copy link
Member

I figured they wanted to prune the search space, but breaking CI is annoying ;) Thanks for the explanation!

@grlee77
Copy link
Contributor

grlee77 commented Jul 29, 2019

Not 100% sure if that is what is going on here, but I had recently experienced similar issues and think that was the cause. I think otherwise packages only tend to get removed if they were "broken", but in those cases they would typically be replaced with a working version with a newer build number.

@thomasjpfan thomasjpfan changed the title [MRG] BLD Uses scikit-image version to work with 3.5-3.7 [MRG] BLD Adds conda free channel for python 3.5 on circleci Jul 29, 2019
@glemaitre
Copy link
Member

You can always pin conda

conda install conda=4.6

The packages will be available there.

@amueller
Copy link
Member

@glemaitre yeah I was also considering that but I feel like we'd just be asking for more issues down the road? Not sure.

@jnothman
Copy link
Member

Oh, this would have saved time fixing the release branches...

Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seemed like bad behaviour to me, @amueller, that old deps were disappearing.

@glemaitre
Copy link
Member

Lots of packages were broken in the last conda version as well. For instance, the csv files of the scikit-learn package were corrupted. I think it was something linked to some compression applied to these files. Maybe conda is rebuilding the packages in the meanwhile.

@rth
Copy link
Member

rth commented Jul 29, 2019

We could also use conda-forge more in the CI. It's more transparent and easier to understand what is happening there.

@glemaitre glemaitre merged commit a72f4dc into scikit-learn:master Jul 30, 2019
@rth
Copy link
Member

rth commented Jul 30, 2019

Thanks! I think this PR could have used a link toward the comment where this issue was detected (#14507) as otherwise @lesteve ended up proposing a independent PR to solve it in #14515

@lesteve
Copy link
Member

lesteve commented Jul 30, 2019

I think this PR could have used a link toward the comment where this issue was detected

That would have helped indeed but to be fair I could have checked existing PRs too ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants