MAINT Deprecate utils.extmath.safe_min #14554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Aug 2, 2019
Co-Authored-By: jeremiedbb <34657725+jeremiedbb@users.noreply.github.com>
jeremiedbb
approved these changes
Aug 2, 2019
thomasjpfan
reviewed
Aug 2, 2019
It's not documented, and therefore I would consider it private (#12927). The deprecation warning is there just to be nice. On a related topic @amueller recently proposed to move these to private import paths without deprecation in #6616 (comment) |
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
amueller
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.extmath.safe_minimplements a min function that also works for sparse arrays, however it should no longer be necessary with the scipy versions we support.