Skip to content

MAINT DOC Fix CircleCI on master #14586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2019
Merged

MAINT DOC Fix CircleCI on master #14586

merged 3 commits into from
Aug 7, 2019

Conversation

rth
Copy link
Member

@rth rth commented Aug 7, 2019 •
edited
Loading

Following #14525 latex generation fails on master with,

! Missing $ inserted.
<inserted text> 
                $
l.23893 of \(\mathcal{O}(\text{n_features}
                                           * n \log(n))\) where \(n\) is the
!  ==> Fatal error occurred, no output PDF file produced!

likely due to the use of underscore in text mode. This tries to fix it.

cc @NicolasHug

@NicolasHug
Copy link
Member

Thanks @rth

Unfortunately the rendered latex shows the backslash.

I'll push n-features and merge if you don't mind? We can't check the PRs CI since we only build latex for master

@NicolasHug
Copy link
Member

I also replaced * with \times, just in case

@rth
Copy link
Member Author

rth commented Aug 7, 2019

I realized that HTML rendering was problematic, forgot to push the fix. It should be n_\text{features} I think.

@rth
Copy link
Member Author

rth commented Aug 7, 2019

We can't check the PRs CI since we only build latex for master

We can with the [doc build] commit message :) Force-pushed to amend my last commit with it.

I also replaced * with \times

I personally prefer \cdot but that also works.

@NicolasHug
Copy link
Member

OK, feel free to merge ;)

@adrinjalali adrinjalali merged commit 7eded0f into scikit-learn:master Aug 7, 2019
@rth rth deleted the fix-ci branch August 7, 2019 14:02
@thomasjpfan thomasjpfan mentioned this pull request Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rth @NicolasHug @adrinjalali