[MRG] MAINT Uses latest version of python #14722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
reviewed
Aug 22, 2019
There was a problem hiding this comment.
Thanks @thomasjpfan ! LGTM, apart for the following comment
| @@ -38,7 +38,8 @@ def test_plot_roc_curve_error_non_binary(data): | |||
| ("auto", "response methods not defined"), | |||
| ("bad_method", "response_method must be 'predict_proba', " | |||
| "'decision_function' or 'auto'")]) | |||
| def test_plot_roc_curve_error_no_response(data_binary, response_method, msg): | |||
| def test_plot_roc_curve_error_no_response(pyplot, data_binary, response_method, | |||
| msg): | |||
There was a problem hiding this comment.
I have been forgetting to branch from upstream/master recently. 😅
rth
approved these changes
Aug 22, 2019
qinhanmin2014
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14630
Removes pin to python 3.7.3 since ContinuumIO/anaconda-issues#11195 is fixed.