Skip to content

CI: Add direct CircleCI artifact link #14731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Conversation

larsoner
Copy link
Contributor

I wrote a little GitHub app to add direct linking to CircleCI artifacts for some repos. It cuts down on number-of-clicks and waiting on CircleCI Artifacts tab to render when reviewing PRs.

See CI status over in scipy/scipy#10707 for an example.

If you do want this (or want to try it at least), you'll need to add the app to sklearn/sklearn, then I can push-force here and you can see what it looks like. The app is not very configurable (see the GitHub page for known limitations) but I suspect it would be useful for sklearn.

cc @jnothman esp. since you posted this a while ago https://discuss.circleci.com/t/easily-get-artifact-url/10394/2

@jnothman
Copy link
Member

jnothman commented Aug 22, 2019 via email

@larsoner
Copy link
Contributor Author

I already set it up to point to _changes :)

@agramfort
Copy link
Member

I just activated the app. You'll need to push another commit

@larsoner
Copy link
Contributor Author

Link to https://71008-843222-gh.circle-artifacts.com/0/doc/_changed.html in the statuses

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@rth rth merged commit 43dd2e8 into scikit-learn:master Aug 23, 2019
@thomasjpfan
Copy link
Member

This is aweseome! Thank you @larsoner !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants