-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[MRG] DOC Link items explictly #14817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC @NicolasHug The time has come to just treat single backticks as double backticks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not checked every line, but I'm happy with this.
Not doing the |
Adding |
hmm, ok, I don't mind it much either way. LGTM once the conflict is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked everything either, but LGTM
Thanks a lot for taking care of this @thomasjpfan
(not merging right away just in case someone else wants a look)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amueller is probably not gonna be happy about this :P
I'm fine with it. |
From: #24104 (comment), @thomasjpfan do you think it would be useful to add a bit in our documentation about single back ticks rendering as code blocks? (Edit: though not sure if there is consensus on what we want people to use...) |
I think most new docstring are single backticks these days. I think it's worth documenting because it is something specific to our sphinx configuration. As for |
Fixes #14665
This PR:
literal
.