[MRG] Make k_means use KMeans instead #14985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+146 −131 :) |
|
Yes, going from a function to a method gives us 4 characters less. |
|
also ping @jeremiedbb since you've been working on the file |
jnothman
approved these changes
Sep 15, 2019
jeremiedbb
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
k_meansuseKMeans.fitinstead of the reverse (see #14897 why)This will help make the changes in #13603 less controversial.
API, functionalities and tests are unchanged.
I hope this also illustrates that
k_meansis mostly a useless wrapper.ping @agramfort @adrinjalali @jnothman .