[MRG] MAINT sync/add support sample_weight with liblinear #15038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amueller you might want to have a look at that |
adrinjalali
reviewed
Oct 2, 2019
|
@adrinjalali any other comments? |
jnothman
reviewed
Oct 23, 2019
adrinjalali
approved these changes
Oct 23, 2019
jnothman
approved these changes
Oct 24, 2019
|
Just realized this kinda needs a whats_new entry. |
NicolasHug
reviewed
Oct 24, 2019
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
|
Thanks @glemaitre ! |
|
Sweet! |
|
Is this functionality in any of the stable sklearn releases? What should I upgrade to? |
|
Not yet. The new release should be out this week |
|
Also, would anyone be keen on updating the old docs to mention the fact that |
Since this is a bug, it would be better to backport the fix. But we will probably release tomorrow, not sure that it would be worth. |
sambhav
added a commit
to sambhav/scikit-learn
that referenced
this pull request
Dec 12, 2019
With the latest release of sklearn, we have merged scikit-learn#15038 which officially adds support for sample weights to these models. Let's update the docs to reflect this.
sambhav
added a commit
to sambhav/scikit-learn
that referenced
this pull request
Dec 12, 2019
With the latest release of sklearn, we have merged scikit-learn#15038 which officially adds support for sample weights to these models. Let's update the docs to reflect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
sample_weightfor the loss/penalty in liblinear.Hopefully it will close:
closes #10873
closes #15018