[MRG] DEP Deprecate None in FeatureUnion #15053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Sep 23, 2019
sklearn/tests/test_pipeline.py
Outdated
| @@ -907,7 +908,9 @@ def test_set_feature_union_steps(): | |||
| assert ['mock__x5'] == ft.get_feature_names() | |||
|
|
|||
|
|
|||
| # TODO: Remove in 0.24 when 'drop' is removed for FeatureUnion | |||
sklearn/tests/test_pipeline.py
Outdated
| @pytest.mark.parametrize('drop', ['drop', None]) | ||
| @ignore_warnings(category=DeprecationWarning) |
There was a problem hiding this comment.
shouldn't we fix the test instead?
adrinjalali
approved these changes
Sep 24, 2019
NicolasHug
approved these changes
Sep 25, 2019
sklearn/tests/test_pipeline.py
Outdated
|
|
||
|
|
||
| # TODO: Remove in 0.24 when None is removed | ||
| def test_feature_union_warns_with_drop(): |
There was a problem hiding this comment.
Suggested change
| def test_feature_union_warns_with_drop(): | |
| def test_feature_union_warns_with_none(): |
NicolasHug
reviewed
Sep 25, 2019
sklearn/tests/test_pipeline.py
Outdated
| @@ -907,6 +907,7 @@ def test_set_feature_union_steps(): | |||
| assert ['mock__x5'] == ft.get_feature_names() | |||
|
|
|||
|
|
|||
| # TODO: Remove in 0.24 when None is removed for FeatureUnion | |||
There was a problem hiding this comment.
Suggested change
| # TODO: Remove in 0.24 when None is removed for FeatureUnion | |
| # TODO: Remove parametrization in 0.24 when None is removed for FeatureUnion |
(we don't want to remove the test!)
rth
approved these changes
Oct 4, 2019
|
linter error. Otherwise LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #14813
What does this implement/fix? Explain your changes.
Deprecates
NoneinFeatureUnion.Any other comments?
Two options to do the same thing is undesirable.