-
-
Notifications
You must be signed in to change notification settings - Fork 26k
CI install scikit-image if we test doc on azure #15065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI is failing |
build_tools/azure/test_docs.sh
Outdated
elif [[ "$DISTRIB" == "ubuntu" ]]; then | ||
source $VIRTUALENV/bin/activate | ||
pip install scikit-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably want to install scikit-image from the system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC our min supported scikit-image is newer than the one available in ubuntu. And in install.sh
we do install a bunch of libs in the environment, so I don't see why this should fail.
Why isn't the CI running? O_o EDIT working |
The system's |
The quick solution is to only install skimage on instances with conda. |
@thomasjpfan but that doesn't fix our issue, since I think one of the tests failing in #14675 is not a conda env. |
I am concerned with how fragile this is. I'll look into this. |
thanks for the fixes @thomasjpfan , should we merge then? |
From my understanding this is for #14675. We would need to disable the doctest for all but one instance (by using |
I'm not sure if I understand what exactly you mean @thomasjpfan |
We use https://github.com/scikit-learn/scikit-learn/blob/master/doc/conftest.py to skip doctest on some files depending if a package is installed. Adding Now that I see that |
Thanks @thomasjpfan , @glemaitre you ok with this now? |
I am fine with it since this is in the doc building dependency |
Thanks @thomasjpfan @adrinjalali |
Let's finish up #14675 |
Related to #14675.
This installs
scikit-image
whenever on azure we test the docs.