[DOC] Removes "documentation" page and adds Other version in nav bar #15121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Oct 2, 2019
| ('Roadmap', pathto('roadmap')), | ||
| ('About us', pathto('about')), | ||
| ('Other Versions', 'https://scikit-learn.org/dev/versions.html'), | ||
| ('Documentation', pathto('documentation'))] |
There was a problem hiding this comment.
I now find this placement quite awkward
There was a problem hiding this comment.
Are you referring to the documentation link?
There was a problem hiding this comment.
Yes, awkward to appear under Other Versions.
Maybe if it's called "documentation home" it's a bit clearer what its role is
|
@NicolasHug Ready for review. |
NicolasHug
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Thanks @thomasjpfan , LGTM.
I don't think the "Documentation" page is really useful anymore.
jnothman
approved these changes
Oct 10, 2019
doc/templates/index.html
Outdated
| @@ -9,7 +9,7 @@ <h1 class="sk-landing-header text-white text-monospace">scikit-learn</h1> | |||
| <h4 class="sk-landing-subheader text-white font-italic mb-3">Machine Learning in Python</h4> | |||
| <a class="btn sk-landing-btn mb-1" href="{{ pathto('getting_started') }}" role="button">Getting Started</a> | |||
| <a class="btn sk-landing-btn mb-1" href="whats_new.html" role="button">Whats New in {{ version }}</a> | |||
| <a class="btn sk-landing-btn mb-1" href="{{ pathto('documentation') }}" role="button">Documentation</a> | |||
| <a class="btn sk-landing-btn mb-1" href="https://github.com/scikit-learn/scikit-learn" role="button">Github</a> | |||
There was a problem hiding this comment.
Suggested change
| <a class="btn sk-landing-btn mb-1" href="https://github.com/scikit-learn/scikit-learn" role="button">Github</a> | |
| <a class="btn sk-landing-btn mb-1" href="https://github.com/scikit-learn/scikit-learn" role="button">GitHub</a> |
|
Thanks @thomasjpfan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "Other Versions" to navbar