Skip to content

Conversation

pspachtholz
Copy link
Contributor

@pspachtholz pspachtholz commented Oct 4, 2019

Reference Issues/PRs

Fixes #15133, towards #3846

What does this implement/fix? Explain your changes.

  • Rewrites the docstring summary to more fully explain how and when crossvalidation is used
    for training and calibrating a classifier
  • Adds two examples to demonstrate and compare usage any other cv option and cv="prefit"

@pspachtholz pspachtholz changed the title [WIP] Improve API documentation of CalibratedClassifierCV [MRG] Improve API documentation of CalibratedClassifierCV Oct 4, 2019
@cmarmo
Copy link
Contributor

cmarmo commented May 22, 2020

Hi @pspachtholz, so sorry, your PR got lost ... Please let us know if you are still interested in working on it. Maybe you could find some time to synchronize your branch with upstream/master? This page will tell you how to do that (if you don't know already). Thanks for your patience!

@MechCoder MechCoder mentioned this pull request May 23, 2020
23 tasks
@pspachtholz
Copy link
Contributor Author

@cmarmo Yes. I'd like to finish it and synchronized my branch.

Copy link
Contributor

@cmarmo cmarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @pspachtholz !
Two minor comments on my side.
@NicolasHug do you mind to have a look at this one? Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pspachtholz

Looks good once @cmarmo 's suggestions are applied

pspachtholz and others added 2 commits May 31, 2020 09:54
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
@cmarmo
Copy link
Contributor

cmarmo commented May 31, 2020

Sorry @pspachtholz! I've skipped one digit...
It should be array([[0.939..., 0.060...]])

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @pspachtholz !

pspachtholz and others added 2 commits June 2, 2020 05:32
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title [MRG] Improve API documentation of CalibratedClassifierCV DOC Improve API documentation of CalibratedClassifierCV Jun 2, 2020
@thomasjpfan thomasjpfan merged commit 7229c05 into scikit-learn:master Jun 2, 2020
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving API documentation for CalibratedClassifierCV
4 participants