-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
DOC Improve API documentation of CalibratedClassifierCV #15134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Improve API documentation of CalibratedClassifierCV #15134
Conversation
Hi @pspachtholz, so sorry, your PR got lost ... Please let us know if you are still interested in working on it. Maybe you could find some time to synchronize your branch with upstream/master? This page will tell you how to do that (if you don't know already). Thanks for your patience! |
@cmarmo Yes. I'd like to finish it and synchronized my branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work @pspachtholz !
Two minor comments on my side.
@NicolasHug do you mind to have a look at this one? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @pspachtholz
Looks good once @cmarmo 's suggestions are applied
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Sorry @pspachtholz! I've skipped one digit... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @pspachtholz !
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reference Issues/PRs
Fixes #15133, towards #3846
What does this implement/fix? Explain your changes.
for training and calibrating a classifier