[MRG] make files private in sklearn.svm #15165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll make them private |
|
Pinging the usual @thomasjpfan @rth @adrinjalali @glemaitre |
adrinjalali
approved these changes
Oct 18, 2019
| @@ -8,6 +8,7 @@ | |||
| # This is a set of 3-tuples consisting of | |||
| # (new_module_name, deprecated_path, correct_import_path) | |||
| _DEPRECATED_MODULES = { | |||
| # TODO: Remove in 0.24 | |||
There was a problem hiding this comment.
line 6 says "remove the whole file in 0.24", we don't need this line :)
|
@thomasjpfan let's please merge before any more conflict appears |
thomasjpfan
approved these changes
Oct 18, 2019
| from . import libsvm, liblinear | ||
| from . import libsvm_sparse | ||
| from . import _libsvm as libsvm | ||
| from .import _liblinear as liblinear |
There was a problem hiding this comment.
This syntax error has been merged to master! Surprisingly, this is actually not considered a syntax error...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make files in sklearn.svm private.
In particular libsvm, liblinear and libsvm_sparse aren't exposed in the
__init__anymoretowards #9250