Skip to content

MAINT Make utlis.fast_dict private #15223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2019

Conversation

NicolasHug
Copy link
Member

Towards #6616 (comment)

thomasjpfan
thomasjpfan previously approved these changes Oct 12, 2019
@thomasjpfan thomasjpfan self-requested a review October 12, 2019 17:50
@thomasjpfan thomasjpfan dismissed their stale review October 12, 2019 17:51

Too many PRs open, clicked approve by accident.

@NicolasHug NicolasHug changed the title [WIP] Make utlis.fast_dict private [MRG] Make utlis.fast_dict private Oct 12, 2019
@NicolasHug
Copy link
Member Author

ping @rth @thomasjpfan @glemaitre @adrinjalali for an easy review?

@thomasjpfan thomasjpfan changed the title [MRG] Make utlis.fast_dict private MAINT Make utlis.fast_dict private Oct 14, 2019
@thomasjpfan thomasjpfan merged commit 5e7ff0d into scikit-learn:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants