Skip to content

[MRG] Deprecate utils.fixes.parallel_helper #15224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MRG] Deprecate utils.fixes.parallel_helper #15224

wants to merge 2 commits into from

Conversation

NicolasHug
Copy link
Member

Towards #6616 (comment)

That thing was a Python 2 workaround so we don't need it anymore.

@NicolasHug NicolasHug changed the title [WIP] Deprecate utils.fixes.parallel_helper [MRG] Deprecate utils.fixes.parallel_helper Oct 12, 2019
@NicolasHug
Copy link
Member Author

ping @rth @thomasjpfan @glemaitre @adrinjalali for an easy review?

thomasjpfan
thomasjpfan approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was nice knowing you Python 2.

@rth
Copy link
Member

rth commented Oct 14, 2019

Maybe let's leave it to #15232 ? I think removing something in sklearn.utils.fixes without deprecation warning as done there is fine, we have been doing that before, and I don't see why anyone would use this with python 3.

@NicolasHug
Copy link
Member Author

Closed in favor of #15232

@NicolasHug NicolasHug closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @rth @thomasjpfan