Skip to content

MNT Make utils.weight_vector and utils.seq_dataset private #15225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2019
Merged

MNT Make utils.weight_vector and utils.seq_dataset private #15225

merged 5 commits into from
Oct 13, 2019

Conversation

NicolasHug
Copy link
Member

towards #6616

@NicolasHug NicolasHug changed the title [WIP] Make utils.weight_vector and utils.seq_dataset private [MRG] Make utils.weight_vector and utils.seq_dataset private Oct 12, 2019
@NicolasHug
Copy link
Member Author

ping @rth @thomasjpfan @glemaitre @adrinjalali for an easy review?

rth
rth approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasHug !

@rth rth changed the title [MRG] Make utils.weight_vector and utils.seq_dataset private MNT Make utils.weight_vector and utils.seq_dataset private Oct 13, 2019
@rth rth merged commit 150e82b into scikit-learn:master Oct 13, 2019
This was referenced Oct 22, 2019
Closed
Merged
@angelaambroz angelaambroz mentioned this pull request Oct 25, 2019
Merged
@SiphonDuck SiphonDuck mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @rth @thomasjpfan