TST Remove redundant py2 test in test_forest #15235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue 'Remove fixes/compat for Python 2' An extra test with a list raised an exception in Python2. Since Python2 is deprecated we do not need this extra test any more.
rth
approved these changes
Oct 13, 2019
|
Please remove the title of this PR to something actually describing the diff though. |
|
@rth are you okay with the title? |
thomasjpfan
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Contributes to #11991
What does this implement/fix? Explain your changes.
An extra test with a list raised an exception in Python2.
Since Python2 is deprecated we do not need this extra test any more.
Any other comments?