Skip to content

[WIP] #15222 Improve docstrings relating to random_state #15300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sara-es
Copy link

@sara-es sara-es commented Oct 19, 2019

svm/_base.py 852 and svm/_classes.py 310 as detailed in #15222.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Improved docstrings related to random_state parameter in svm/_base.py 852
and svm/_classes.py 310 as detailed in #15222 .

Any other comments?

I'll keep working through the list of other modules needing similar fixes.

svm/_base.py 852 and svm/_classes.py 310 as detailed in scikit-learn#15222.
@cmarmo
Copy link
Contributor

cmarmo commented Jan 8, 2020

Dear @sara-es, I'm working on preparing next skl sprints. Your PR is meant to fix part of an issue we are planning to propose. You have labeled it as Work In Progress, that's probably why nobody has taken the time to check on it (but sorry for that, anyway)... do you plan to improve it? As a first comment I can just say that the ref to Glossary is missing... but it will not take a lot of time to add.
Please, let us know.... thanks for your patience and collaboration

@jeremiedbb
Copy link
Member

Fixed in #16316, closing. Sorry @sara-es we did not see your PR on time :/

@jeremiedbb jeremiedbb closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants