Skip to content

[MRG] Make files private for sklearn.metrics and sklearn.metrics.cluster #15306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 23, 2019
Merged

[MRG] Make files private for sklearn.metrics and sklearn.metrics.cluster #15306

merged 11 commits into from
Oct 23, 2019

Conversation

NicolasHug
Copy link
Member

towards #9250 (comment)

@NicolasHug NicolasHug mentioned this pull request Oct 20, 2019
Closed
@NicolasHug NicolasHug changed the title [WIP] Make files private for sklearn.metrics and sklearn.metrics.cluster [MRG] Make files private for sklearn.metrics and sklearn.metrics.cluster Oct 22, 2019
@NicolasHug
Copy link
Member Author

@adrinjalali @thomasjpfan

glemaitre
glemaitre reviewed Oct 23, 2019
View reviewed changes
sklearn/metrics/tests/test_score_objects.py Outdated
@@ -234,6 +235,7 @@ def test_check_scoring_and_check_multimetric_scoring():
('accuracy', 'precision'), ['precision', 'accuracy'],
{'accuracy': make_scorer(accuracy_score),
'precision': make_scorer(precision_score)}):
print(scoring)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unattended printing :)

glemaitre
glemaitre approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart of the print function

@glemaitre glemaitre self-assigned this Oct 23, 2019
@glemaitre glemaitre merged commit e947689 into scikit-learn:master Oct 23, 2019
@glemaitre
Copy link
Member

I pushed directly the nitpick since there is already one approval. Thanks @NicolasHug

@NicolasHug
Copy link
Member Author

Thanks @glemaitre !

@binzhang-u5f6c binzhang-u5f6c mentioned this pull request May 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees

@glemaitre glemaitre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @glemaitre @thomasjpfan