Skip to content

[MRG] Make modules private in manifold #15318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 22, 2019
Merged

[MRG] Make modules private in manifold #15318

merged 5 commits into from
Oct 22, 2019

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Oct 21, 2019 •
edited
Loading

Reference Issues/PRs

Partially addresses #9250

CC @NicolasHug @adrinjalali

@NicolasHug NicolasHug mentioned this pull request Oct 21, 2019
Closed
@thomasjpfan thomasjpfan changed the title [MRG] Deprecated submodules of manifold [MRG] Make modules private in manifold Oct 21, 2019
@qinhanmin2014 qinhanmin2014 merged commit 46c3142 into scikit-learn:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @NicolasHug @qinhanmin2014