Skip to content

[MRG] MNT Make modules private in guassian_process #15320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2019
Merged

[MRG] MNT Make modules private in guassian_process #15320

merged 3 commits into from
Oct 28, 2019

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Oct 21, 2019 •
edited
Loading

Reference Issues/PRs

Partially addresses #9250

What does this implement/fix? Explain your changes.

Any other comments?

@NicolasHug NicolasHug mentioned this pull request Oct 21, 2019
Closed
@thomasjpfan thomasjpfan changed the title [MRG] MNT Deprecated paths in guassian_process [MRG] MNT Make modules private in guassian_process Oct 21, 2019
glemaitre
glemaitre approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After solving the conflict, this one is LGTM.

@qinhanmin2014 qinhanmin2014 merged commit a311ec0 into scikit-learn:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @glemaitre @qinhanmin2014