Skip to content

[MRG] MNT Make modules private in linear_model #15324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 23, 2019
Merged

[MRG] MNT Make modules private in linear_model #15324

merged 10 commits into from
Oct 23, 2019

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Partially addresses #9250

Any other comments?

CC @NicolasHug @adrinjalali

NicolasHug
NicolasHug reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd_fast
sag_fast
sag

are missing it seems

NicolasHug
NicolasHug approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo merge conflicts.

Thanks @thomasjpfan

@NicolasHug NicolasHug mentioned this pull request Oct 23, 2019
Closed
@glemaitre glemaitre self-requested a review October 23, 2019 13:25
glemaitre
glemaitre approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre merged commit 0a7adef into scikit-learn:master Oct 23, 2019
@glemaitre
Copy link
Member

@adrinjalali I think we add a collision while merging master. Are the changes related to the website intended: e0b90ef ?

@glemaitre
Copy link
Member

Apparently, we removed the Donate button from the website.

@adrinjalali adrinjalali mentioned this pull request Oct 24, 2019
Merged
@kumpera kumpera mentioned this pull request Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @glemaitre @NicolasHug @adrinjalali