[MRG] [DOC] multiclass and types_of_target #15333

lucyleeow · 2019-10-22T15:27:15Z

Reference Issues/PRs

fixes #9777 ( also takes over #11213 )

What does this implement/fix? Explain your changes.

This PR improves the multiclass and type-of-target documentation

Any other comments?

This PR should be entered before #9059

glemaitre

Apparently this link is broken: https://github.com/scikit-learn/scikit-learn/pull/15333/files#diff-81351ea50baa58c22524abc7bfba8a7eR265

glemaitre

I looked at the summary for the moment. Just some thoughts.

doc/modules/multiclass.rst

pedugnat · 2019-10-23T16:06:53Z

Hi! Just red the new version, and it is indeed much clearer. I think the best part is that you added the shapes and the type of matrices expected as input.

NicolasHug

Thanks @lucyleeow , made a few comments

doc/modules/multiclass.rst

lucyleeow · 2019-10-25T09:10:01Z

Thanks @cmarmo - I was meant to say that I think the warning is due to the example not being built as it builds fine locally.

lucyleeow · 2019-11-06T09:32:19Z

ping @NicolasHug @glemaitre and @jnothman - I've made the suggested changes. Any further suggestions?

NicolasHug · 2019-11-06T12:17:02Z

Did you git push @lucyleeow ? The changes aren't reflected in this PR

lucyleeow · 2019-11-06T12:27:12Z

Sorry! I forgot to push (:man_facepalming:)

NicolasHug

Thanks @lucyleeow , a few comments but mostly looks good now. LGTM

doc/modules/multiclass.rst

glemaitre

In general it looks good. I only have to minor proposals.

glemaitre · 2019-11-07T13:14:30Z

doc/modules/multiclass.rst

+  Valid representation :term:`multilabel` `y` is either dense (or sparse)
+  :term:`binary` matrix of shape ``(n_samples, n_classes)`` with multiple
+  active elements per row to denote that the sample belongs to multiple classes.
+  Each column represents a class.


I would think that with each example we could print a minimum python/numpy example of y_pred obtained. We could use the targets given in each example to have a link.

What is the best procedure to do this? Screenshot and save png or is there a smarter way?

Oh, I meant something simpler. E.g. for multiclass:

print(np.array(['apple', 'pear', 'apricot', ...]))

lucyleeow · 2019-11-07T15:09:25Z

@glemaitre hopefully this is what you were after but please let me know if not.

glemaitre · 2019-11-07T15:25:05Z

doc/modules/multiclass.rst

@@ -50,6 +53,13 @@ regression is also supported.
  For example, prediction of the topics relevant to a text document or video.
  The document or video may be about one of 'religion', 'politics', 'finance'
  or 'education', several of the topic classes or all of the topic classes.
+  An example of ``y`` for 3 samples:
+
+    >>> y = np.array([[1,0,0,1], [0,0,1,1], [0,0,0,0]])                                  


I would put these examples after the description of the valid representation

Add the sparse representation as well

ping @glemaitre

glemaitre · 2019-11-19T16:56:00Z

@lucyleeow Could you check the linter. It is not happy and it does run the doc :)

glemaitre · 2019-11-19T16:54:48Z

doc/modules/multiclass.rst

+    >>> y = np.array([[1,0,0,1], [0,0,1,1], [0,0,0,0]])                                  
+    >>> print(y)                                                                         
+    [[1 0 0 1]
+    [0 0 1 1]


is it missing a space? The linter is not happy

glemaitre · 2019-11-19T16:57:06Z

doc/modules/multiclass.rst

+      the columns, in order, are orange, apple and pear:
+
+        >>> from scipy import sparse
+        >>> row_ind = np.array([0,1,2])                                                      


Suggested change

>>> row_ind = np.array([0,1,2])

>>> row_ind = np.array([0, 1, 2])

Be careful you have some trailing spaces

glemaitre · 2019-11-19T16:57:34Z

doc/modules/multiclass.rst

+
+        >>> from scipy import sparse
+        >>> row_ind = np.array([0,1,2])                                                      
+        >>> col_ind = np.array([1,2,1])  


Suggested change

>>> col_ind = np.array([1,2,1])

>>> col_ind = np.array([1, 2, 1])

glemaitre · 2019-11-19T16:58:19Z

doc/modules/multiclass.rst

+  sample has been labelled with. An example of a dense matrix ``y`` for 3
+  samples:
+
+    >>> y = np.array([[1,0,0,1], [0,0,1,1], [0,0,0,0]])                                  


Suggested change

>>> y = np.array([[1,0,0,1], [0,0,1,1], [0,0,0,0]])

>>> y = np.array([[1, 0, 0, 1], [0, 0, 1, 1], [0, 0, 0, 0]])

glemaitre · 2019-11-19T16:58:39Z

doc/modules/multiclass.rst

+  :term:`binary` matrix of shape ``(n_samples, n_classes)``. Each column
+  represents a class. The ``1``'s in each row denote the positive classes a
+  sample has been labelled with. An example of a dense matrix ``y`` for 3
+  samples:


Shoud you have :: (double semicolon)?

lucyleeow · 2019-12-06T11:06:08Z

ping @glemaitre

glemaitre · 2019-12-06T12:09:40Z

The linter is not happy :)

lucyleeow · 2019-12-06T12:14:34Z

@glemaitre the error is /bin/bash: ./build_tools/circle/flake8_diff.sh: No such file or directory - I think the name of the linter file has been changed. I can fetch and rebase?

glemaitre · 2019-12-06T12:49:25Z

Oh your PR is out of synchornization with mater. Could you synchronize with master by mergin master into your branch (the script was renamed linting.sh)

lucyleeow · 2019-12-06T15:07:31Z

@glemaitre code cov decreased? 🤷‍♀️

glemaitre · 2019-12-06T16:26:46Z

@lucyleeow codecov is wrong :). It happens when we only touch documentation.

glemaitre · 2019-12-06T16:28:05Z

I am happy with the changes. Let's merge.

glemaitre · 2019-12-06T16:28:43Z

@lucyleeow Thanks a lot.

@nkish

* DOC fixed default values in dbscan (#15753) * DOC fix incorrect branch reference in contributing doc (#15779) * DOC relabel Feature -> Efficiency in change log (#15770) * DOC fixed Birch default value (#15780) * STY Minior change on code padding in website theme (#15768) * DOC Fix yticklabels order in permutation importances example (#15799) * Fix yticklabels order in permutation importances example * STY Update wrapper width (#15793) * DOC Long sentence was hard to parse and ambiguous in _classification.py (#15769) * DOC Removed duplicate 'classes_' attribute in Naive Bayes classifiers (#15811) * BUG Fixes pandas dataframe bug with boolean dtypes (#15797) * BUG Returns only public estimators in all_estimators (#15380) * DOC improve doc for multiclass and types_of_target (#15333) * TST Increases tol for check_pca_float_dtype_preservation assertion (#15775) * update _alpha_grid class in _coordinate_descent.py (#15835) * FIX Explicit conversion of ndarray to object dtype. (#15832) * BLD Parallelize sphinx builds on circle ci (#15745) * DOC correct url for preprocessing (#15853) * MNT avoid generating too many cross links in examples (#15844) * DOC Correct wrong doc in precision_recall_fscore_support (#15833) * DOC add comment in check_pca_float_dtype_preservation (#15819) Documenting the changes in #15775 * DOC correct indents in docstring _split.py (#15843) * DOC fix docstring of KMeans based on sklearn guideline (#15754) * DOC fix docstring of AgglomerativeClustering based on sklearn guideline (#15764) * DOC fix docstring of AffinityPropagation based on sklearn guideline (#15777) * DOC fixed SpectralCoclustering and SpectralBiclustering docstrings following sklearn guideline (#15778) * DOC fix FeatureAgglomeration and MiniBatchKMeans docstring following sklearn guideline (#15809) * TST Specify random_state in test_cv_iterable_wrapper (#15829) * DOC Include LinearSV{C, R} in models that support sample_weights (#15871) * DOC correct some indents (#15875) * DOC Fix documentation of default values in tree classes (#15870) * DOC fix typo in docstring (#15887) * DOC FIX default value for xticks_rotation in plot_confusion_matrix (#15890) * Fix imports in pip3 ubuntu by suffixing affected files (#15891) * MNT Raise erorr when normalize is invalid in confusion_matrix (#15888) * [MRG] DOC Increases search results for API object results (#15574) * MNT Ignores warning in pyamg for deprecated scipy.random (#15914) * DOC Instructions to troubleshoot Windows path length limit (#15916) * DOC add versionadded directive to some estimators (#15849) * DOC clarify doc-string of roc_auc_score and add references (#15293) * MNT Adds skip lint to azure pipeline CI (#15904) * BLD Fixes bug when building with NO_MATHJAX=1 (#15892) * [MRG] BUG Checks to number of axes in passed in ax more generically (#15760) * EXA Minor fixes in plot_sparse_logistic_regression_20newsgroups.py (#15925) * BUG Do not shadow public functions with deprecated modules (#15846) * Import sklearn._distributor_init first (#15929) * DOC Fix typos, via a Levenshtein-style corrector (#15923) * DOC in canned comment, mention that PR title becomes commit me… (#15935) * DOC/EXA Correct spelling of "Classification" (#15938) * BUG fix pip3 ubuntu update by suffixing file (#15928) * [MRG] Ways to compute center_shift_total were different in "full" and "elkan" algorithms. (#15930) * TST Fixes integer test for train and test indices (#15941) * BUG ensure that parallel/sequential give the same permutation importances (#15933) * Formatting fixes in changelog (#15944) * MRG FIX: order of values of self.quantiles_ in QuantileTransformer (#15751) * [MRG] BUG Fixes constrast in plot_confusion_matrix (#15936) * BUG use zero_division argument in classification_report (#15879) * DOC change logreg solver in plot_logistic_path (#15927) * DOC fix whats new ordering (#15961) * COSMIT use np.iinfo to define the max int32 (#15960) * DOC Apply numpydoc validation to VotingRegressor methods (#15969) Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> * DOC improve naive_bayes.py documentation (#15943) Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> * DOC Fix default values in Perceptron documentation (#15965) * DOC Improve default values in logistic documentation (#15966) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * DOC Improve documentation of default values for imputers (#15964) * EXA/MAINT Simplify code in manifold learning example (#15949) * DOC Improve default values in SGD documentation (#15967) * DOC Improve defaults in neural network documentation (#15968) * FIX use safe_sparse_dot for callable kernel in LabelSpreading (#15868) * BUG Adds attributes back to check_is_fitted (#15947) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * DOC update check_is_fitted what's new * DOC change python-devel to python3-devel for yum. (#15986) * DOC Correct the default value of values_format in plot_confusion_matrix (#15981) * [MRG] MNT Updates pypy to use 7.2.0 (#15954) * FIX Add missing 'values_format' param to disp.plot() in plot_confusion_matrix (#15937) * FIX support scalar values in fit_params in SearchCV (#15863) * support a scalar fit param * pep8 * TST add test for desired behavior * FIX introduce _check_fit_params to validate parameters * DOC update whats new * TST tests both grid-search and randomize-search * PEP8 * DOC revert unecessary change * TST add test for _check_fit_params * olivier comments * TST fixes * DOC whats new * DOC whats new * TST revert type of error * add olivier suggestions * address olivier comments * address thomas comments * PEP8 * comments olivier * TST fix test by passing X * avoid to call twice tocsr * add case column/row sparse in check_fit_param * provide optional indices * TST check content when indexing params * PEP8 * TST update tests to check identity * stupid fix * use a distribution in RandomizedSearchCV * MNT add lightgbm to one of the CI build * move to another build * do not install dependencies lightgbm * MNT comments on the CI setup * address some comments * Test fit_params compat without dependency on lightgbm Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Remove abstractmethod that silently brake downstream packages (#15996) * FIX restore BaseNB._check_X without abstractmethod decoration (#15997) * Update v0.22 changelog for 0.22.1 (#16002) - set the date - move entry for quantile transformer to the 0.22.1 section - fix alphabetical ordering of modules * STY Removes hidden scroll bar (#15999) * Flake8 fixes * Fix: remove left-over lines that should have been deleted during conflict resolution when rebasing * Fix missing imports * Update version * Fix test_check_is_fitted * Make test_sag_regressor_computed_correctly deterministic (#16003) Fix #15818. Co-authored-by: cgsavard <claire.savard@colorado.edu> Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Matt Hall <matt@agilegeoscience.com> Co-authored-by: Kathryn Poole <kathryn.poole2@gmail.com> Co-authored-by: lucyleeow <jliu176@gmail.com> Co-authored-by: JJmistry <jayminm22@gmail.com> Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es> Co-authored-by: SylvainLan <sylvain.s.lannuzel@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Hanmin Qin <qinhanmin2005@sina.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Vachan D A <vachanda@users.noreply.github.com> Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Co-authored-by: wenliwyan <12013376+wenliwyan@users.noreply.github.com> Co-authored-by: shivamgargsya <shivam.gargshya@gmail.com> Co-authored-by: Reshama Shaikh <rs2715@stern.nyu.edu> Co-authored-by: Oliver Urs Lenz <oulenz@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Brian Wignall <BrianWignall@gmail.com> Co-authored-by: Ritchie Ng <ritchieng@u.nus.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: inderjeet <43402782+inder128@users.noreply.github.com> Co-authored-by: scibol <scibol@users.noreply.github.com> Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com> Co-authored-by: Bibhash Chandra Mitra <bibhashm220896@gmail.com> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> Co-authored-by: @nkish <19225359+ankishb@users.noreply.github.com> Co-authored-by: Pulkit Mehta <pulkit_mehta_work@yahoo.com> Co-authored-by: David Breuer <DavidBreuer@users.noreply.github.com> Co-authored-by: Niklas <niklas.sm+github@gmail.com> Co-authored-by: Windber <guolipengyeah@126.com> Co-authored-by: Stephen Blystone <29995339+blynotes@users.noreply.github.com> Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>

@nkish

* DOC fixed default values in dbscan (scikit-learn#15753) * DOC fix incorrect branch reference in contributing doc (scikit-learn#15779) * DOC relabel Feature -> Efficiency in change log (scikit-learn#15770) * DOC fixed Birch default value (scikit-learn#15780) * STY Minior change on code padding in website theme (scikit-learn#15768) * DOC Fix yticklabels order in permutation importances example (scikit-learn#15799) * Fix yticklabels order in permutation importances example * STY Update wrapper width (scikit-learn#15793) * DOC Long sentence was hard to parse and ambiguous in _classification.py (scikit-learn#15769) * DOC Removed duplicate 'classes_' attribute in Naive Bayes classifiers (scikit-learn#15811) * BUG Fixes pandas dataframe bug with boolean dtypes (scikit-learn#15797) * BUG Returns only public estimators in all_estimators (scikit-learn#15380) * DOC improve doc for multiclass and types_of_target (scikit-learn#15333) * TST Increases tol for check_pca_float_dtype_preservation assertion (scikit-learn#15775) * update _alpha_grid class in _coordinate_descent.py (scikit-learn#15835) * FIX Explicit conversion of ndarray to object dtype. (scikit-learn#15832) * BLD Parallelize sphinx builds on circle ci (scikit-learn#15745) * DOC correct url for preprocessing (scikit-learn#15853) * MNT avoid generating too many cross links in examples (scikit-learn#15844) * DOC Correct wrong doc in precision_recall_fscore_support (scikit-learn#15833) * DOC add comment in check_pca_float_dtype_preservation (scikit-learn#15819) Documenting the changes in scikit-learn#15775 * DOC correct indents in docstring _split.py (scikit-learn#15843) * DOC fix docstring of KMeans based on sklearn guideline (scikit-learn#15754) * DOC fix docstring of AgglomerativeClustering based on sklearn guideline (scikit-learn#15764) * DOC fix docstring of AffinityPropagation based on sklearn guideline (scikit-learn#15777) * DOC fixed SpectralCoclustering and SpectralBiclustering docstrings following sklearn guideline (scikit-learn#15778) * DOC fix FeatureAgglomeration and MiniBatchKMeans docstring following sklearn guideline (scikit-learn#15809) * TST Specify random_state in test_cv_iterable_wrapper (scikit-learn#15829) * DOC Include LinearSV{C, R} in models that support sample_weights (scikit-learn#15871) * DOC correct some indents (scikit-learn#15875) * DOC Fix documentation of default values in tree classes (scikit-learn#15870) * DOC fix typo in docstring (scikit-learn#15887) * DOC FIX default value for xticks_rotation in plot_confusion_matrix (scikit-learn#15890) * Fix imports in pip3 ubuntu by suffixing affected files (scikit-learn#15891) * MNT Raise erorr when normalize is invalid in confusion_matrix (scikit-learn#15888) * [MRG] DOC Increases search results for API object results (scikit-learn#15574) * MNT Ignores warning in pyamg for deprecated scipy.random (scikit-learn#15914) * DOC Instructions to troubleshoot Windows path length limit (scikit-learn#15916) * DOC add versionadded directive to some estimators (scikit-learn#15849) * DOC clarify doc-string of roc_auc_score and add references (scikit-learn#15293) * MNT Adds skip lint to azure pipeline CI (scikit-learn#15904) * BLD Fixes bug when building with NO_MATHJAX=1 (scikit-learn#15892) * [MRG] BUG Checks to number of axes in passed in ax more generically (scikit-learn#15760) * EXA Minor fixes in plot_sparse_logistic_regression_20newsgroups.py (scikit-learn#15925) * BUG Do not shadow public functions with deprecated modules (scikit-learn#15846) * Import sklearn._distributor_init first (scikit-learn#15929) * DOC Fix typos, via a Levenshtein-style corrector (scikit-learn#15923) * DOC in canned comment, mention that PR title becomes commit me… (scikit-learn#15935) * DOC/EXA Correct spelling of "Classification" (scikit-learn#15938) * BUG fix pip3 ubuntu update by suffixing file (scikit-learn#15928) * [MRG] Ways to compute center_shift_total were different in "full" and "elkan" algorithms. (scikit-learn#15930) * TST Fixes integer test for train and test indices (scikit-learn#15941) * BUG ensure that parallel/sequential give the same permutation importances (scikit-learn#15933) * Formatting fixes in changelog (scikit-learn#15944) * MRG FIX: order of values of self.quantiles_ in QuantileTransformer (scikit-learn#15751) * [MRG] BUG Fixes constrast in plot_confusion_matrix (scikit-learn#15936) * BUG use zero_division argument in classification_report (scikit-learn#15879) * DOC change logreg solver in plot_logistic_path (scikit-learn#15927) * DOC fix whats new ordering (scikit-learn#15961) * COSMIT use np.iinfo to define the max int32 (scikit-learn#15960) * DOC Apply numpydoc validation to VotingRegressor methods (scikit-learn#15969) Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> * DOC improve naive_bayes.py documentation (scikit-learn#15943) Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> * DOC Fix default values in Perceptron documentation (scikit-learn#15965) * DOC Improve default values in logistic documentation (scikit-learn#15966) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * DOC Improve documentation of default values for imputers (scikit-learn#15964) * EXA/MAINT Simplify code in manifold learning example (scikit-learn#15949) * DOC Improve default values in SGD documentation (scikit-learn#15967) * DOC Improve defaults in neural network documentation (scikit-learn#15968) * FIX use safe_sparse_dot for callable kernel in LabelSpreading (scikit-learn#15868) * BUG Adds attributes back to check_is_fitted (scikit-learn#15947) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * DOC update check_is_fitted what's new * DOC change python-devel to python3-devel for yum. (scikit-learn#15986) * DOC Correct the default value of values_format in plot_confusion_matrix (scikit-learn#15981) * [MRG] MNT Updates pypy to use 7.2.0 (scikit-learn#15954) * FIX Add missing 'values_format' param to disp.plot() in plot_confusion_matrix (scikit-learn#15937) * FIX support scalar values in fit_params in SearchCV (scikit-learn#15863) * support a scalar fit param * pep8 * TST add test for desired behavior * FIX introduce _check_fit_params to validate parameters * DOC update whats new * TST tests both grid-search and randomize-search * PEP8 * DOC revert unecessary change * TST add test for _check_fit_params * olivier comments * TST fixes * DOC whats new * DOC whats new * TST revert type of error * add olivier suggestions * address olivier comments * address thomas comments * PEP8 * comments olivier * TST fix test by passing X * avoid to call twice tocsr * add case column/row sparse in check_fit_param * provide optional indices * TST check content when indexing params * PEP8 * TST update tests to check identity * stupid fix * use a distribution in RandomizedSearchCV * MNT add lightgbm to one of the CI build * move to another build * do not install dependencies lightgbm * MNT comments on the CI setup * address some comments * Test fit_params compat without dependency on lightgbm Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Remove abstractmethod that silently brake downstream packages (scikit-learn#15996) * FIX restore BaseNB._check_X without abstractmethod decoration (scikit-learn#15997) * Update v0.22 changelog for 0.22.1 (scikit-learn#16002) - set the date - move entry for quantile transformer to the 0.22.1 section - fix alphabetical ordering of modules * STY Removes hidden scroll bar (scikit-learn#15999) * Flake8 fixes * Fix: remove left-over lines that should have been deleted during conflict resolution when rebasing * Fix missing imports * Update version * Fix test_check_is_fitted * Make test_sag_regressor_computed_correctly deterministic (scikit-learn#16003) Fix scikit-learn#15818. Co-authored-by: cgsavard <claire.savard@colorado.edu> Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Matt Hall <matt@agilegeoscience.com> Co-authored-by: Kathryn Poole <kathryn.poole2@gmail.com> Co-authored-by: lucyleeow <jliu176@gmail.com> Co-authored-by: JJmistry <jayminm22@gmail.com> Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es> Co-authored-by: SylvainLan <sylvain.s.lannuzel@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Hanmin Qin <qinhanmin2005@sina.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Vachan D A <vachanda@users.noreply.github.com> Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Co-authored-by: wenliwyan <12013376+wenliwyan@users.noreply.github.com> Co-authored-by: shivamgargsya <shivam.gargshya@gmail.com> Co-authored-by: Reshama Shaikh <rs2715@stern.nyu.edu> Co-authored-by: Oliver Urs Lenz <oulenz@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Brian Wignall <BrianWignall@gmail.com> Co-authored-by: Ritchie Ng <ritchieng@u.nus.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: inderjeet <43402782+inder128@users.noreply.github.com> Co-authored-by: scibol <scibol@users.noreply.github.com> Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com> Co-authored-by: Bibhash Chandra Mitra <bibhashm220896@gmail.com> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> Co-authored-by: @nkish <19225359+ankishb@users.noreply.github.com> Co-authored-by: Pulkit Mehta <pulkit_mehta_work@yahoo.com> Co-authored-by: David Breuer <DavidBreuer@users.noreply.github.com> Co-authored-by: Niklas <niklas.sm+github@gmail.com> Co-authored-by: Windber <guolipengyeah@126.com> Co-authored-by: Stephen Blystone <29995339+blynotes@users.noreply.github.com> Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>

Joan Massich and others added 17 commits July 20, 2018 19:19

Use consistent naming

0aee15a

[draft] Use the same 'fruit' example to drive the conversation

b17598a

[emtpy] trigger circle

2e03d7a

[empty] push to sik PR

2c13dcf

add the examples to the explanation

27b08c4

Merge branch 'master' into multiclass_type_of_target

2770491

rework multiclass explanations

c5d4cc9

add type column, clarify multiclass

6405f11

fix format

47c7b12

add clarification to table

316b4b1

clarify multioutput reg

beda428

fix rst table

a5e008e

clarify multiclass class

6764b25

Merge branch 'master' into multiclass_type_of_target

81f2d3a

Merge branch 'master' into multiclass_type_of_target

529268f

fix rst bolding

e8c22ac

trigger CI

ef98a66

massich mentioned this pull request Oct 22, 2019

[MRG] [RFC] multiclass and types_of_target #11213

Closed

glemaitre reviewed Oct 22, 2019

View reviewed changes

doc/modules/multiclass.rst Outdated Show resolved Hide resolved

doc/modules/multiclass.rst Outdated Show resolved Hide resolved

doc/modules/multiclass.rst Outdated Show resolved Hide resolved

NicolasHug reviewed Oct 24, 2019

View reviewed changes

lucyleeow added 2 commits October 24, 2019 13:27

address comments

ebda055

add multilabel example

9e56dba

cmarmo mentioned this pull request Oct 25, 2019

[BLD] CircleCI failed when a PR generates sphinx warnings #15355

Closed

NicolasHug approved these changes Nov 6, 2019

View reviewed changes

address jnothman's comments

9898fed

glemaitre reviewed Nov 7, 2019

View reviewed changes

add examples for each type

3c97b20

lucyleeow added 3 commits November 7, 2019 16:28

formatting, import numpy

90132f5

amend to be 3 samples

35c307e

amend output to 3 samples

38d3bf6

glemaitre reviewed Nov 7, 2019

View reviewed changes

lucyleeow added 2 commits November 7, 2019 20:52

add sparse examples

d97ddbe

name import correctly

46a74d1

glemaitre reviewed Nov 19, 2019

View reviewed changes

space formating

ec95ceb

Merge branch 'master' into multiclass_type_of_target

2bba72b

glemaitre merged commit e4c0ada into scikit-learn:master Dec 6, 2019

AlexandreAbraham mentioned this pull request Dec 23, 2019

RandomForestClassifier does not handle sparse multilabel-indicator y #15958

Closed

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Dec 31, 2019

DOC improve doc for multiclass and types_of_target (scikit-learn#15333)

9e81fa8

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jan 2, 2020

DOC improve doc for multiclass and types_of_target (scikit-learn#15333)

1237e40

panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020

DOC improve doc for multiclass and types_of_target (scikit-learn#15333)

a0c11a4

lucyleeow deleted the multiclass_type_of_target branch October 21, 2023 03:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG] [DOC] multiclass and types_of_target #15333

[MRG] [DOC] multiclass and types_of_target #15333

lucyleeow commented Oct 22, 2019

glemaitre left a comment

glemaitre left a comment

pedugnat commented Oct 23, 2019

NicolasHug left a comment

lucyleeow commented Oct 25, 2019

lucyleeow commented Nov 6, 2019 •

edited

Loading

NicolasHug commented Nov 6, 2019

lucyleeow commented Nov 6, 2019 •

edited

Loading

NicolasHug left a comment

glemaitre left a comment

glemaitre Nov 7, 2019

lucyleeow Nov 7, 2019

glemaitre Nov 7, 2019

lucyleeow commented Nov 7, 2019

glemaitre Nov 7, 2019

glemaitre Nov 7, 2019

lucyleeow Nov 8, 2019

lucyleeow Nov 13, 2019

glemaitre commented Nov 19, 2019

glemaitre Nov 19, 2019

glemaitre Nov 19, 2019

glemaitre Nov 19, 2019

glemaitre Nov 19, 2019

glemaitre Nov 19, 2019

glemaitre Nov 19, 2019

lucyleeow commented Dec 6, 2019

glemaitre commented Dec 6, 2019

lucyleeow commented Dec 6, 2019 •

edited

Loading

glemaitre commented Dec 6, 2019

lucyleeow commented Dec 6, 2019

glemaitre commented Dec 6, 2019

glemaitre commented Dec 6, 2019

glemaitre commented Dec 6, 2019

	>>> row_ind = np.array([0,1,2])
	>>> row_ind = np.array([0, 1, 2])

	>>> col_ind = np.array([1,2,1])
	>>> col_ind = np.array([1, 2, 1])

	>>> y = np.array([[1,0,0,1], [0,0,1,1], [0,0,0,0]])
	>>> y = np.array([[1, 0, 0, 1], [0, 0, 1, 1], [0, 0, 0, 0]])

[MRG] [DOC] multiclass and types_of_target #15333

[MRG] [DOC] multiclass and types_of_target #15333

Conversation

lucyleeow commented Oct 22, 2019

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

glemaitre left a comment

Choose a reason for hiding this comment

glemaitre left a comment

Choose a reason for hiding this comment

pedugnat commented Oct 23, 2019

NicolasHug left a comment

Choose a reason for hiding this comment

lucyleeow commented Oct 25, 2019

lucyleeow commented Nov 6, 2019 • edited Loading

NicolasHug commented Nov 6, 2019

lucyleeow commented Nov 6, 2019 • edited Loading

NicolasHug left a comment

Choose a reason for hiding this comment

glemaitre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucyleeow commented Nov 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glemaitre commented Nov 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucyleeow commented Dec 6, 2019

glemaitre commented Dec 6, 2019

lucyleeow commented Dec 6, 2019 • edited Loading

glemaitre commented Dec 6, 2019

lucyleeow commented Dec 6, 2019

glemaitre commented Dec 6, 2019

glemaitre commented Dec 6, 2019

glemaitre commented Dec 6, 2019

lucyleeow commented Nov 6, 2019 •

edited

Loading

lucyleeow commented Nov 6, 2019 •

edited

Loading

lucyleeow commented Dec 6, 2019 •

edited

Loading