[MRG] MNT Make modules private in inspection #15334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NicolasHug @adrinjalali This should be ready now. |
NicolasHug
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
If you're wondering @adrinjalali there's a bug in pytest 3.8.1, hence the CI changes
|
I really think the CI should be documented... I'd be useful to have a document explaining what CI is in charge of what, and why we need to pin down versions in some cases. |
|
What kind of bugs? |
For some reason pytest was confusing but it's been fixed in the next versions so no need to worry about it |
|
OK, I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #9250