[MRG] MNT Make modules private in decomposition #15344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Oct 23, 2019
|
tests failing @thomasjpfan |
|
Can't import fabs, it is cimported. :( |
qinhanmin2014
approved these changes
Oct 28, 2019
sklearn/decomposition/__init__.py
Outdated
| from ._kernel_pca import KernelPCA | ||
| from ._sparse_pca import SparsePCA, MiniBatchSparsePCA | ||
| from ._truncated_svd import TruncatedSVD | ||
| from ._fastica_ import FastICA, fastica |
There was a problem hiding this comment.
should we remove the trailing _?
There was a problem hiding this comment.
We typically haven't for the other instances, maybe we can leave it for a post-process PR
There was a problem hiding this comment.
My intention is to make use of this chance to get rid of some bad file names :)
There was a problem hiding this comment.
Sure. All I'm saying is, there are other files that we have renamed to _file_.py that are already in master.
|
Let's rename |
This reverts commit a4944e5.
|
should we ignore the flake8 errors? @thomasjpfan |
|
Yea we have been ignore flake8 errors that were already present in the file to make it easier for PRs to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #9250
Any other comments?
CC @NicolasHug @adrinjalali