Skip to content

[MRG] Make modules private in feature_selection #15376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2019
Merged

[MRG] Make modules private in feature_selection #15376

merged 5 commits into from
Oct 29, 2019

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Partially addresses #9250

Any other comments?

CC @NicolasHug @adrinjalali

@adrinjalali
Copy link
Member

tests fail.

../1/s/sklearn/feature_selection/tests/test_mutual_info.py:9: in <module>
    from sklearn.feature_extraction import (mutual_info_regression,
E   ImportError: cannot import name 'mutual_info_regression'

adrinjalali
adrinjalali approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green.

@qinhanmin2014 qinhanmin2014 merged commit 6769490 into scikit-learn:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @adrinjalali @qinhanmin2014