[MRG] BUG Returns only public estimators in all_estimators #15380

thomasjpfan · 2019-10-28T17:55:41Z

This PR updates all_estimators such that:

It does not error when pytest or Cython is not installed.
Removes absolute import of sklearn.
Only returns public classes

WIP because there was an adjustment made for pypy.

rth

Looks good.

Could you please double check that the output of this function before and after the PR is identical (except for the private estimators)?

For debugging PyPy I find it easier to download the latest PyPy binary and then create a venv locally with pypy -m venv pypy-env than doing changes back and forth of config.yml..

…factor

thomasjpfan · 2019-10-31T15:37:09Z

I checked all_estimators before and after as follows:

from sklearn.utils import all_estimators
from sklearn.utils import all_estimators_new

est_new = set(name for name, _ in all_estimators_new())
est_orig = set(name for name, _ in all_estimators())

print(est_new - est_orig)
# set()

print(est_orig - est_new)
# {'_BaseEncoder',
#  '_BaseImputer',
#  '_BaseRidgeCV',
#  '_BinMapper',
#  '_BinaryGaussianProcessClassifierLaplace',
#  '_ConstantPredictor',
#  '_RidgeGCV',
#  '_SigmoidCalibration'}

Only the private classes are excluded.

thomasjpfan · 2019-10-31T15:42:47Z

For debugging PyPy I find it easier to download the latest PyPy binary and then create a venv locally with pypy -m venv pypy-env than doing changes back and forth of config.yml..

Given that the CI uses a docker image for pypy, reproducing the test locally with docker isn't too bad as well.

Side note: I wish there was a git tag to trigger pypy. I am a bit tempted to have a pypy test instance on travis so we can use a commit tag to trigger the test.

…factor

thomasjpfan · 2019-11-06T21:30:26Z

@NicolasHug Most likely need something like this if all_estimator is public?

NicolasHug

Looks better than before indeed, thanks @thomasjpfan

NicolasHug · 2019-11-06T21:45:38Z

sklearn/utils/__init__.py

-        classes = inspect.getmembers(module, inspect.isclass)
-        all_classes.extend(classes)
+    modules_to_ignore = set(["tests", "externals", "setup"])
+    root = str(Path(__file__).parent.parent)


Suggested change

root = str(Path(__file__).parent.parent)

root = str(Path(__file__).parent.parent) # sklearn package

NicolasHug · 2019-11-06T21:46:25Z

sklearn/utils/__init__.py

+            classes = [(name, est_cls) for name, est_cls in classes
+                       if not name.startswith("_")]
+
+            # remove FeatureHasher


FeatureHasher is not defined in PYPY It was skipped in the master version of all_estimators as well. #11540

NicolasHug · 2019-11-06T21:47:39Z

sklearn/utils/__init__.py

-            module = __import__(modname, fromlist="dummy")
-        classes = inspect.getmembers(module, inspect.isclass)
-        all_classes.extend(classes)
+    modules_to_ignore = set(["tests", "externals", "setup"])


just use the set syntax {'a', 'b'}?

NicolasHug · 2019-11-06T21:50:12Z

sklearn/utils/__init__.py

+        for importer, modname, ispkg in pkgutil.walk_packages(
+                path=[root], prefix='sklearn.'):
+            mod_parts = modname.split(".")
+            if modules_to_ignore & set(mod_parts) or "._" in modname:


I'd find using any slightly more readable here, instead of set intersection

Like this?

if any(part in modules_to_ignore for part in mod_parts)

NicolasHug · 2019-11-06T22:11:21Z

what happened to _svmlight_format? it just works now?

thomasjpfan · 2019-11-06T22:21:14Z

No classes in _svmlight_format to import.

amueller · 2019-11-15T17:42:52Z

Hm I'm not entirely sure how intentional this was. I think generally I assumed private classes that we don't want to test are abstract. But I guess that might not be true?
I'm fine with the change though, it makes things a bit easier in the common case.

rth

LGTM, given the private classes that are excluded #15380 (comment)

Coverage looks fine, despite the CI failure.

jnothman · 2019-11-18T13:04:50Z

(Why does the XHR retrieve the .html rather than the .rst file??)

thomasjpfan · 2019-11-18T16:42:05Z

(Why does the XHR retrieve the .html rather than the .rst file??)

@jnothman I suspect this comment is for #15574?

jnothman · 2019-11-18T19:51:26Z

Yes indeed. They were discussed at the same time...

…factor

thomasjpfan · 2019-11-20T21:28:20Z

Added test into test_estimator_checks which makes sure all_estimators work when pytest is not installed.

rth · 2019-12-06T13:10:01Z

Should be easy to merge. Maybe @NicolasHug or @glemaitre ?

rth · 2019-12-06T13:18:12Z

Never mind. Merging with a +2 and since I didn't see significant objections in the discussion.

)

@nkish

* DOC fixed default values in dbscan (#15753) * DOC fix incorrect branch reference in contributing doc (#15779) * DOC relabel Feature -> Efficiency in change log (#15770) * DOC fixed Birch default value (#15780) * STY Minior change on code padding in website theme (#15768) * DOC Fix yticklabels order in permutation importances example (#15799) * Fix yticklabels order in permutation importances example * STY Update wrapper width (#15793) * DOC Long sentence was hard to parse and ambiguous in _classification.py (#15769) * DOC Removed duplicate 'classes_' attribute in Naive Bayes classifiers (#15811) * BUG Fixes pandas dataframe bug with boolean dtypes (#15797) * BUG Returns only public estimators in all_estimators (#15380) * DOC improve doc for multiclass and types_of_target (#15333) * TST Increases tol for check_pca_float_dtype_preservation assertion (#15775) * update _alpha_grid class in _coordinate_descent.py (#15835) * FIX Explicit conversion of ndarray to object dtype. (#15832) * BLD Parallelize sphinx builds on circle ci (#15745) * DOC correct url for preprocessing (#15853) * MNT avoid generating too many cross links in examples (#15844) * DOC Correct wrong doc in precision_recall_fscore_support (#15833) * DOC add comment in check_pca_float_dtype_preservation (#15819) Documenting the changes in #15775 * DOC correct indents in docstring _split.py (#15843) * DOC fix docstring of KMeans based on sklearn guideline (#15754) * DOC fix docstring of AgglomerativeClustering based on sklearn guideline (#15764) * DOC fix docstring of AffinityPropagation based on sklearn guideline (#15777) * DOC fixed SpectralCoclustering and SpectralBiclustering docstrings following sklearn guideline (#15778) * DOC fix FeatureAgglomeration and MiniBatchKMeans docstring following sklearn guideline (#15809) * TST Specify random_state in test_cv_iterable_wrapper (#15829) * DOC Include LinearSV{C, R} in models that support sample_weights (#15871) * DOC correct some indents (#15875) * DOC Fix documentation of default values in tree classes (#15870) * DOC fix typo in docstring (#15887) * DOC FIX default value for xticks_rotation in plot_confusion_matrix (#15890) * Fix imports in pip3 ubuntu by suffixing affected files (#15891) * MNT Raise erorr when normalize is invalid in confusion_matrix (#15888) * [MRG] DOC Increases search results for API object results (#15574) * MNT Ignores warning in pyamg for deprecated scipy.random (#15914) * DOC Instructions to troubleshoot Windows path length limit (#15916) * DOC add versionadded directive to some estimators (#15849) * DOC clarify doc-string of roc_auc_score and add references (#15293) * MNT Adds skip lint to azure pipeline CI (#15904) * BLD Fixes bug when building with NO_MATHJAX=1 (#15892) * [MRG] BUG Checks to number of axes in passed in ax more generically (#15760) * EXA Minor fixes in plot_sparse_logistic_regression_20newsgroups.py (#15925) * BUG Do not shadow public functions with deprecated modules (#15846) * Import sklearn._distributor_init first (#15929) * DOC Fix typos, via a Levenshtein-style corrector (#15923) * DOC in canned comment, mention that PR title becomes commit me… (#15935) * DOC/EXA Correct spelling of "Classification" (#15938) * BUG fix pip3 ubuntu update by suffixing file (#15928) * [MRG] Ways to compute center_shift_total were different in "full" and "elkan" algorithms. (#15930) * TST Fixes integer test for train and test indices (#15941) * BUG ensure that parallel/sequential give the same permutation importances (#15933) * Formatting fixes in changelog (#15944) * MRG FIX: order of values of self.quantiles_ in QuantileTransformer (#15751) * [MRG] BUG Fixes constrast in plot_confusion_matrix (#15936) * BUG use zero_division argument in classification_report (#15879) * DOC change logreg solver in plot_logistic_path (#15927) * DOC fix whats new ordering (#15961) * COSMIT use np.iinfo to define the max int32 (#15960) * DOC Apply numpydoc validation to VotingRegressor methods (#15969) Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> * DOC improve naive_bayes.py documentation (#15943) Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> * DOC Fix default values in Perceptron documentation (#15965) * DOC Improve default values in logistic documentation (#15966) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * DOC Improve documentation of default values for imputers (#15964) * EXA/MAINT Simplify code in manifold learning example (#15949) * DOC Improve default values in SGD documentation (#15967) * DOC Improve defaults in neural network documentation (#15968) * FIX use safe_sparse_dot for callable kernel in LabelSpreading (#15868) * BUG Adds attributes back to check_is_fitted (#15947) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * DOC update check_is_fitted what's new * DOC change python-devel to python3-devel for yum. (#15986) * DOC Correct the default value of values_format in plot_confusion_matrix (#15981) * [MRG] MNT Updates pypy to use 7.2.0 (#15954) * FIX Add missing 'values_format' param to disp.plot() in plot_confusion_matrix (#15937) * FIX support scalar values in fit_params in SearchCV (#15863) * support a scalar fit param * pep8 * TST add test for desired behavior * FIX introduce _check_fit_params to validate parameters * DOC update whats new * TST tests both grid-search and randomize-search * PEP8 * DOC revert unecessary change * TST add test for _check_fit_params * olivier comments * TST fixes * DOC whats new * DOC whats new * TST revert type of error * add olivier suggestions * address olivier comments * address thomas comments * PEP8 * comments olivier * TST fix test by passing X * avoid to call twice tocsr * add case column/row sparse in check_fit_param * provide optional indices * TST check content when indexing params * PEP8 * TST update tests to check identity * stupid fix * use a distribution in RandomizedSearchCV * MNT add lightgbm to one of the CI build * move to another build * do not install dependencies lightgbm * MNT comments on the CI setup * address some comments * Test fit_params compat without dependency on lightgbm Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Remove abstractmethod that silently brake downstream packages (#15996) * FIX restore BaseNB._check_X without abstractmethod decoration (#15997) * Update v0.22 changelog for 0.22.1 (#16002) - set the date - move entry for quantile transformer to the 0.22.1 section - fix alphabetical ordering of modules * STY Removes hidden scroll bar (#15999) * Flake8 fixes * Fix: remove left-over lines that should have been deleted during conflict resolution when rebasing * Fix missing imports * Update version * Fix test_check_is_fitted * Make test_sag_regressor_computed_correctly deterministic (#16003) Fix #15818. Co-authored-by: cgsavard <claire.savard@colorado.edu> Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Matt Hall <matt@agilegeoscience.com> Co-authored-by: Kathryn Poole <kathryn.poole2@gmail.com> Co-authored-by: lucyleeow <jliu176@gmail.com> Co-authored-by: JJmistry <jayminm22@gmail.com> Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es> Co-authored-by: SylvainLan <sylvain.s.lannuzel@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Hanmin Qin <qinhanmin2005@sina.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Vachan D A <vachanda@users.noreply.github.com> Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Co-authored-by: wenliwyan <12013376+wenliwyan@users.noreply.github.com> Co-authored-by: shivamgargsya <shivam.gargshya@gmail.com> Co-authored-by: Reshama Shaikh <rs2715@stern.nyu.edu> Co-authored-by: Oliver Urs Lenz <oulenz@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Brian Wignall <BrianWignall@gmail.com> Co-authored-by: Ritchie Ng <ritchieng@u.nus.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: inderjeet <43402782+inder128@users.noreply.github.com> Co-authored-by: scibol <scibol@users.noreply.github.com> Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com> Co-authored-by: Bibhash Chandra Mitra <bibhashm220896@gmail.com> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> Co-authored-by: @nkish <19225359+ankishb@users.noreply.github.com> Co-authored-by: Pulkit Mehta <pulkit_mehta_work@yahoo.com> Co-authored-by: David Breuer <DavidBreuer@users.noreply.github.com> Co-authored-by: Niklas <niklas.sm+github@gmail.com> Co-authored-by: Windber <guolipengyeah@126.com> Co-authored-by: Stephen Blystone <29995339+blynotes@users.noreply.github.com> Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>

)

@nkish

* DOC fixed default values in dbscan (scikit-learn#15753) * DOC fix incorrect branch reference in contributing doc (scikit-learn#15779) * DOC relabel Feature -> Efficiency in change log (scikit-learn#15770) * DOC fixed Birch default value (scikit-learn#15780) * STY Minior change on code padding in website theme (scikit-learn#15768) * DOC Fix yticklabels order in permutation importances example (scikit-learn#15799) * Fix yticklabels order in permutation importances example * STY Update wrapper width (scikit-learn#15793) * DOC Long sentence was hard to parse and ambiguous in _classification.py (scikit-learn#15769) * DOC Removed duplicate 'classes_' attribute in Naive Bayes classifiers (scikit-learn#15811) * BUG Fixes pandas dataframe bug with boolean dtypes (scikit-learn#15797) * BUG Returns only public estimators in all_estimators (scikit-learn#15380) * DOC improve doc for multiclass and types_of_target (scikit-learn#15333) * TST Increases tol for check_pca_float_dtype_preservation assertion (scikit-learn#15775) * update _alpha_grid class in _coordinate_descent.py (scikit-learn#15835) * FIX Explicit conversion of ndarray to object dtype. (scikit-learn#15832) * BLD Parallelize sphinx builds on circle ci (scikit-learn#15745) * DOC correct url for preprocessing (scikit-learn#15853) * MNT avoid generating too many cross links in examples (scikit-learn#15844) * DOC Correct wrong doc in precision_recall_fscore_support (scikit-learn#15833) * DOC add comment in check_pca_float_dtype_preservation (scikit-learn#15819) Documenting the changes in scikit-learn#15775 * DOC correct indents in docstring _split.py (scikit-learn#15843) * DOC fix docstring of KMeans based on sklearn guideline (scikit-learn#15754) * DOC fix docstring of AgglomerativeClustering based on sklearn guideline (scikit-learn#15764) * DOC fix docstring of AffinityPropagation based on sklearn guideline (scikit-learn#15777) * DOC fixed SpectralCoclustering and SpectralBiclustering docstrings following sklearn guideline (scikit-learn#15778) * DOC fix FeatureAgglomeration and MiniBatchKMeans docstring following sklearn guideline (scikit-learn#15809) * TST Specify random_state in test_cv_iterable_wrapper (scikit-learn#15829) * DOC Include LinearSV{C, R} in models that support sample_weights (scikit-learn#15871) * DOC correct some indents (scikit-learn#15875) * DOC Fix documentation of default values in tree classes (scikit-learn#15870) * DOC fix typo in docstring (scikit-learn#15887) * DOC FIX default value for xticks_rotation in plot_confusion_matrix (scikit-learn#15890) * Fix imports in pip3 ubuntu by suffixing affected files (scikit-learn#15891) * MNT Raise erorr when normalize is invalid in confusion_matrix (scikit-learn#15888) * [MRG] DOC Increases search results for API object results (scikit-learn#15574) * MNT Ignores warning in pyamg for deprecated scipy.random (scikit-learn#15914) * DOC Instructions to troubleshoot Windows path length limit (scikit-learn#15916) * DOC add versionadded directive to some estimators (scikit-learn#15849) * DOC clarify doc-string of roc_auc_score and add references (scikit-learn#15293) * MNT Adds skip lint to azure pipeline CI (scikit-learn#15904) * BLD Fixes bug when building with NO_MATHJAX=1 (scikit-learn#15892) * [MRG] BUG Checks to number of axes in passed in ax more generically (scikit-learn#15760) * EXA Minor fixes in plot_sparse_logistic_regression_20newsgroups.py (scikit-learn#15925) * BUG Do not shadow public functions with deprecated modules (scikit-learn#15846) * Import sklearn._distributor_init first (scikit-learn#15929) * DOC Fix typos, via a Levenshtein-style corrector (scikit-learn#15923) * DOC in canned comment, mention that PR title becomes commit me… (scikit-learn#15935) * DOC/EXA Correct spelling of "Classification" (scikit-learn#15938) * BUG fix pip3 ubuntu update by suffixing file (scikit-learn#15928) * [MRG] Ways to compute center_shift_total were different in "full" and "elkan" algorithms. (scikit-learn#15930) * TST Fixes integer test for train and test indices (scikit-learn#15941) * BUG ensure that parallel/sequential give the same permutation importances (scikit-learn#15933) * Formatting fixes in changelog (scikit-learn#15944) * MRG FIX: order of values of self.quantiles_ in QuantileTransformer (scikit-learn#15751) * [MRG] BUG Fixes constrast in plot_confusion_matrix (scikit-learn#15936) * BUG use zero_division argument in classification_report (scikit-learn#15879) * DOC change logreg solver in plot_logistic_path (scikit-learn#15927) * DOC fix whats new ordering (scikit-learn#15961) * COSMIT use np.iinfo to define the max int32 (scikit-learn#15960) * DOC Apply numpydoc validation to VotingRegressor methods (scikit-learn#15969) Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> * DOC improve naive_bayes.py documentation (scikit-learn#15943) Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> * DOC Fix default values in Perceptron documentation (scikit-learn#15965) * DOC Improve default values in logistic documentation (scikit-learn#15966) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * DOC Improve documentation of default values for imputers (scikit-learn#15964) * EXA/MAINT Simplify code in manifold learning example (scikit-learn#15949) * DOC Improve default values in SGD documentation (scikit-learn#15967) * DOC Improve defaults in neural network documentation (scikit-learn#15968) * FIX use safe_sparse_dot for callable kernel in LabelSpreading (scikit-learn#15868) * BUG Adds attributes back to check_is_fitted (scikit-learn#15947) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * DOC update check_is_fitted what's new * DOC change python-devel to python3-devel for yum. (scikit-learn#15986) * DOC Correct the default value of values_format in plot_confusion_matrix (scikit-learn#15981) * [MRG] MNT Updates pypy to use 7.2.0 (scikit-learn#15954) * FIX Add missing 'values_format' param to disp.plot() in plot_confusion_matrix (scikit-learn#15937) * FIX support scalar values in fit_params in SearchCV (scikit-learn#15863) * support a scalar fit param * pep8 * TST add test for desired behavior * FIX introduce _check_fit_params to validate parameters * DOC update whats new * TST tests both grid-search and randomize-search * PEP8 * DOC revert unecessary change * TST add test for _check_fit_params * olivier comments * TST fixes * DOC whats new * DOC whats new * TST revert type of error * add olivier suggestions * address olivier comments * address thomas comments * PEP8 * comments olivier * TST fix test by passing X * avoid to call twice tocsr * add case column/row sparse in check_fit_param * provide optional indices * TST check content when indexing params * PEP8 * TST update tests to check identity * stupid fix * use a distribution in RandomizedSearchCV * MNT add lightgbm to one of the CI build * move to another build * do not install dependencies lightgbm * MNT comments on the CI setup * address some comments * Test fit_params compat without dependency on lightgbm Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Remove abstractmethod that silently brake downstream packages (scikit-learn#15996) * FIX restore BaseNB._check_X without abstractmethod decoration (scikit-learn#15997) * Update v0.22 changelog for 0.22.1 (scikit-learn#16002) - set the date - move entry for quantile transformer to the 0.22.1 section - fix alphabetical ordering of modules * STY Removes hidden scroll bar (scikit-learn#15999) * Flake8 fixes * Fix: remove left-over lines that should have been deleted during conflict resolution when rebasing * Fix missing imports * Update version * Fix test_check_is_fitted * Make test_sag_regressor_computed_correctly deterministic (scikit-learn#16003) Fix scikit-learn#15818. Co-authored-by: cgsavard <claire.savard@colorado.edu> Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Matt Hall <matt@agilegeoscience.com> Co-authored-by: Kathryn Poole <kathryn.poole2@gmail.com> Co-authored-by: lucyleeow <jliu176@gmail.com> Co-authored-by: JJmistry <jayminm22@gmail.com> Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es> Co-authored-by: SylvainLan <sylvain.s.lannuzel@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Hanmin Qin <qinhanmin2005@sina.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Vachan D A <vachanda@users.noreply.github.com> Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Co-authored-by: wenliwyan <12013376+wenliwyan@users.noreply.github.com> Co-authored-by: shivamgargsya <shivam.gargshya@gmail.com> Co-authored-by: Reshama Shaikh <rs2715@stern.nyu.edu> Co-authored-by: Oliver Urs Lenz <oulenz@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Brian Wignall <BrianWignall@gmail.com> Co-authored-by: Ritchie Ng <ritchieng@u.nus.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: inderjeet <43402782+inder128@users.noreply.github.com> Co-authored-by: scibol <scibol@users.noreply.github.com> Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com> Co-authored-by: Bibhash Chandra Mitra <bibhashm220896@gmail.com> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> Co-authored-by: @nkish <19225359+ankishb@users.noreply.github.com> Co-authored-by: Pulkit Mehta <pulkit_mehta_work@yahoo.com> Co-authored-by: David Breuer <DavidBreuer@users.noreply.github.com> Co-authored-by: Niklas <niklas.sm+github@gmail.com> Co-authored-by: Windber <guolipengyeah@126.com> Co-authored-by: Stephen Blystone <29995339+blynotes@users.noreply.github.com> Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>

thomasjpfan added 4 commits October 28, 2019 13:26

BUG Returns only public estimators

3987a8b

ENH Trigger pypy

5ed8d14

BUG Fixes all_estimators

5483f92

ENH Better handling on pypy

96972dc

rth reviewed Oct 31, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into all_estimators_re…

8ecb36f

…factor

thomasjpfan added 5 commits October 31, 2019 13:44

Merge remote-tracking branch 'upstream/master' into all_estimators_re…

065c466

…factor

FIX Uses FutureWarning

478a538

FIX python 35 does not suport pathlib in walk_packages

fc9acef

Merge remote-tracking branch 'upstream/master' into all_estimators_re…

3bbe71b

…factor

REV

cc7bca5

thomasjpfan changed the title ~~[WIP] BUG Returns only public estimators in all_estimators~~ [MRG] BUG Returns only public estimators in all_estimators Nov 1, 2019

NicolasHug reviewed Nov 6, 2019

View reviewed changes

CLN Address comments

efa253f

NicolasHug approved these changes Nov 6, 2019

View reviewed changes

CLN Uses any

57c9eca

rth approved these changes Nov 15, 2019

View reviewed changes

thomasjpfan added 2 commits November 20, 2019 15:25

Merge remote-tracking branch 'upstream/master' into all_estimators_re…

d11e830

…factor

ENH Adds test to test_estimator_checksD

0838ae7

thomasjpfan added this to the 0.22.1 milestone Dec 3, 2019

rth merged commit 4ce39db into scikit-learn:master Dec 6, 2019

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Dec 31, 2019

BUG Returns only public estimators in all_estimators (scikit-learn#15380

463898a

)

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jan 2, 2020

BUG Returns only public estimators in all_estimators (scikit-learn#15380

e547c90

)

panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020

BUG Returns only public estimators in all_estimators (scikit-learn#15380

b5e526e

)

adrinjalali mentioned this pull request Apr 23, 2020

DOC cleaning up to 0.23/whats new #17015

Merged

adrinjalali mentioned this pull request Apr 27, 2020

Fix 0.23 whats_new entries #17057

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG] BUG Returns only public estimators in all_estimators #15380

[MRG] BUG Returns only public estimators in all_estimators #15380

thomasjpfan commented Oct 28, 2019

rth left a comment

thomasjpfan commented Oct 31, 2019

thomasjpfan commented Oct 31, 2019

thomasjpfan commented Nov 6, 2019

NicolasHug left a comment

NicolasHug Nov 6, 2019

NicolasHug Nov 6, 2019

thomasjpfan Nov 6, 2019

NicolasHug Nov 6, 2019

NicolasHug Nov 6, 2019

thomasjpfan Nov 6, 2019

NicolasHug Nov 6, 2019

NicolasHug commented Nov 6, 2019

thomasjpfan commented Nov 6, 2019

amueller commented Nov 15, 2019

rth left a comment •

edited

Loading

jnothman commented Nov 18, 2019

thomasjpfan commented Nov 18, 2019

jnothman commented Nov 18, 2019 via email

thomasjpfan commented Nov 20, 2019

rth commented Dec 6, 2019

rth commented Dec 6, 2019

	root = str(Path(__file__).parent.parent)
	root = str(Path(__file__).parent.parent) # sklearn package

[MRG] BUG Returns only public estimators in all_estimators #15380

[MRG] BUG Returns only public estimators in all_estimators #15380

Conversation

thomasjpfan commented Oct 28, 2019

rth left a comment

Choose a reason for hiding this comment

thomasjpfan commented Oct 31, 2019

thomasjpfan commented Oct 31, 2019

thomasjpfan commented Nov 6, 2019

NicolasHug left a comment

Choose a reason for hiding this comment

NicolasHug Nov 6, 2019

Choose a reason for hiding this comment

NicolasHug Nov 6, 2019

Choose a reason for hiding this comment

thomasjpfan Nov 6, 2019

Choose a reason for hiding this comment

NicolasHug Nov 6, 2019

Choose a reason for hiding this comment

NicolasHug Nov 6, 2019

Choose a reason for hiding this comment

thomasjpfan Nov 6, 2019

Choose a reason for hiding this comment

NicolasHug Nov 6, 2019

Choose a reason for hiding this comment

NicolasHug commented Nov 6, 2019

thomasjpfan commented Nov 6, 2019

amueller commented Nov 15, 2019

rth left a comment • edited Loading

Choose a reason for hiding this comment

jnothman commented Nov 18, 2019

thomasjpfan commented Nov 18, 2019

jnothman commented Nov 18, 2019 via email

thomasjpfan commented Nov 20, 2019

rth commented Dec 6, 2019

rth commented Dec 6, 2019

rth left a comment •

edited

Loading