Skip to content

[WIP] FIX backward compat in _parallel_build_trees #15417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] FIX backward compat in _parallel_build_trees #15417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sklearn/ensemble/_forest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@ def _parallel_build_trees(tree, forest, X, y, sample_weight, tree_idx, n_trees,
if verbose > 1:
print("building tree %d of %d" % (tree_idx + 1, n_trees))

if n_samples_bootstrap is None:
# for backward-compatibility, we can set the number of samples in each
# bootstrap to the number of samples in X in case `n_samples_bootstrap`
# is not defined
n_samples_bootstrap = X.shape[0]

if forest.bootstrap:
n_samples = X.shape[0]
if sample_weight is None:
Expand Down