[MRG] add transform y section to faq.rst #15484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, alternative extensions
thomasjpfan
reviewed
Nov 2, 2019
Changed to TransformedTargetRegressor Re-formatted transform y section Added links to pipegraph imbalanced-learn
TomDLT
reviewed
Nov 2, 2019
styling change Co-Authored-By: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
:class:`sklearn.compose.TransformedTargetRegressor`
TomDLT
reviewed
Nov 2, 2019
|
I think this should include a bit more of the discussion. Note that we have solved for the case where y has an invertible transformation applied before training and inverted after prediction... And we hope to solve for use cases where y should be transformed at training time and not at test time, for resampling and similar uses, like at imbalanced learn. In general these use cases should be solved with a custom meta estimator rather than a Pipeline |
Link to 4143 issue
Added discussion from jnothman
updated language so it's more of a suggestion
|
@jnothman , @TomDLT , @thomasjpfan have all comments been addressed here? Thanks! |
jnothman
approved these changes
Nov 20, 2019
|
Thanks @theoptips ! |
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 25, 2019
jnothman
pushed a commit
that referenced
this pull request
Nov 28, 2019
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add transform y in a pipeline Q and A to FAQ.
Reference Issues/PRs
Fixes #12587
What does this implement/fix? Explain your changes.
Add transform y section, related discussion, suggested libraries to FAQ
Any other comments?
N/A