-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[MRG] adding as_frame functionality for california housing dataset loader #15486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
78a196f
adding as_frame functionality for california housing dataset loader
gitsteph d604f4b
fixes for as_frame to fetch_california_housing
gitsteph 0a01ecf
minor change
gitsteph e00f4f4
forgot to rename feature_names to columns here
gitsteph 3bda9b5
changes to use pandas concat and make conversion to df more generaliz…
gitsteph 0dba66a
moved _convert_data_dataframe to _base.py
gitsteph df9f086
breaking at 79 chars
gitsteph 5019c9e
added test_fetch_asframe
gitsteph 587be05
moved test to test_california_housing.py
gitsteph f8eeba9
moved return_X_y handling below as_frame check
gitsteph ee19ac7
fixed linting issues caught by flake8
gitsteph 19ed2f3
using pytest.importorskip to handle test environments without pandas …
gitsteph 45940b2
skip test if dataset is not available in test env
gitsteph a6fcb50
Update sklearn/datasets/tests/test_california_housing.py
gitsteph e3db481
Update sklearn/datasets/tests/test_california_housing.py
gitsteph 4c946e0
Merge remote-tracking branch 'upstream/master' into pr/15486
thomasjpfan 20daa13
Merge remote-tracking branch 'upstream/master' into pr/15486
thomasjpfan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to better handle the case where both
return_X_y
andas_frame
areTrue
. If they are both true, this will returnX
andy
as pandas objects.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY to @wconnell for this comment => #15486 (comment)