Skip to content

[MRG] Prevent hyphenation in parameter description #15499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2019
Merged

[MRG] Prevent hyphenation in parameter description #15499

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daf0783
remove linebreak hyphen from parameter descriptions (#12941)
loftiskg Nov 2, 2019
2dd348b
remove linebreak hyphen from parameter descriptions (#12941)
loftiskg Nov 2, 2019
018acdc
Merge branch 'fix_doc_hyphenation_loftiskg' of https://github.com/lof…
loftiskg Nov 2, 2019
77733a1
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn…
loftiskg Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/themes/scikit-learn-modern/static/css/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,10 @@ div.body img {
height: unset!important; /* Needed because sphinx sets the height */
}

div.body dd > p {
Copy link
Member

@TomDLT TomDLT Nov 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change is not located in doc/themes/scikit-learn/static/nature.css_t as suggested in #12941 (comment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that previous comment sort of threw me for a loop.

I think there was a change to which stylesheet the documentation uses since that last comment. doc/themes/scikit-learn-modern/static/css/theme.css was the only stylesheet that I could change that would eventually be linked with the page in question.

I did a quick search, and I think it happened in this merge: #14849

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah @thomasjpfan rewrote the frontend / css

hyphens: none;
}

img.align-center, .figure.align-center, object.align-center {
display: block;
margin-left: auto;
Expand Down