[DOC] ensure all attributes are documented for Perceptron #14312 #15507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change your PR title to
|
eickenberg
reviewed
Nov 2, 2019
| coef_ : array, shape = [1, n_features] if n_classes == 2 else [n_classes,\ | ||
| n_features] | ||
| Weights assigned to the features. | ||
|
|
||
| intercept_ : array, shape = [1] if n_classes == 2 else [n_classes] | ||
| Constants in decision function. | ||
|
|
||
| loss_function_ : concrete LossFunction |
There was a problem hiding this comment.
It should probably say loss_function_ : callable
eickenberg
reviewed
Nov 2, 2019
| coef_ : array, shape = [1, n_features] if n_classes == 2 else [n_classes,\ | ||
| n_features] | ||
| Weights assigned to the features. | ||
|
|
||
| intercept_ : array, shape = [1] if n_classes == 2 else [n_classes] | ||
| Constants in decision function. | ||
|
|
||
| loss_function_ : concrete LossFunction | ||
| The function that determines the loss, or difference between the \ |
There was a problem hiding this comment.
Mention that it is the perceptron loss (defined here https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/_stochastic_gradient.py#L428)
|
Sorry @pwalchessen but this has been fixed in #15521. I'm closing this one. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the loss function attribute to Perceptron and alphabetizes all of the attributes.
Original problem:
as discussed in #13385 we need to ensure all attributes are documented.