Skip to content

[MRG + 2] add pairwise property to basesearchcv #15524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xun-tang
Copy link
Contributor

@xun-tang xun-tang commented Nov 3, 2019

Reference Issues/PRs

Fixes #13920. Pulled from a stalled PR #13925.

What does this implement/fix? Explain your changes.

Any other comments?

My first non-documentation PR on sklearn. Comments welcome.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xun-tang , just a few comments but LGTM

@xun-tang xun-tang changed the title [MRG] add pairwise property to basesearchcv [MRG + 2] add pairwise property to basesearchcv Nov 6, 2019
@cmarmo
Copy link
Contributor

cmarmo commented Nov 10, 2019

@jnothman , @NicolasHug if you are happy with the changes, this one could be merge?

@jnothman jnothman merged commit 3ef8357 into scikit-learn:master Nov 10, 2019
@jnothman
Copy link
Member

Thanks @xun-tang

@xun-tang xun-tang deleted the xun-13925-add_pairwise_property_to_basesearchcv branch November 27, 2019 17:04
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested Cross Validation for precomputed KNN
6 participants