DOC Add version_added label for impute module #15549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Nov 6, 2019
sklearn/impute/_base.py
Outdated
| @@ -120,6 +120,8 @@ class SimpleImputer(_BaseImputer): | |||
|
|
|||
| Read more in the :ref:`User Guide <impute>`. | |||
|
|
|||
| .. versionadded:: 0.14 | |||
There was a problem hiding this comment.
This has only been available as SimpleImputer since 0.20
versionadded helps users understand whether the same tool can be imported in different versions, so the fact that the functionality existed since 0.14 is irrelevant
There was a problem hiding this comment.
That's clear.
Maybe we could mention it ? with something like:
Suggested change
| .. versionadded:: 0.14 | |
| .. versionadded:: 0.20 | |
| Moved from Imputer in sklearn.preprocessing. |
There was a problem hiding this comment.
At first, I was not convinced about mentioning this detail. But after seeing a lot of SO question, I think this worth mentioning something.
.. versionadded:: 0.20
`SimpleImputer` replaces the previous `sklearn.preprocessing.Imputer`
estimator which is now removed.
glemaitre
requested changes
Jan 9, 2020
There was a problem hiding this comment.
@TwsThomas Could you make the change I think that we could merge it after.
glemaitre
approved these changes
Jan 9, 2020
|
Thanks @TwsThomas |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes partially #15426
What does this implement/fix? Explain your changes.
Update the version added tag for the imputer class.
Any other comments?
Might be part of the PR #15482 ?