MAINT Add _distributor_init.py #15570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy has `_distributor_init.py`: https://github.com/numpy/numpy/blob/master/numpy/_distributor_init.py This PR adds one for scikit-learn. The intent is to create a place to add distributor specific logic, e.g. to implement behavior like in scikit-learn#14247 (comment)
jeremiedbb
reviewed
Nov 8, 2019
|
ping. |
jnothman
approved these changes
Nov 19, 2019
|
@rth are we okay to merge? Does your addition of Needs Decision imply that we cannot rely on two approvals? |
rth
approved these changes
Nov 19, 2019
|
Thanks @oleksandr-pavlyk ! We should backport this to 0.23.X so it could be included in the release.. |
MDouriez
pushed a commit
to MDouriez/scikit-learn
that referenced
this pull request
Nov 20, 2019
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 25, 2019
jnothman
pushed a commit
that referenced
this pull request
Nov 28, 2019
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy has
_distributor_init.py:https://github.com/numpy/numpy/blob/master/numpy/_distributor_init.py
This PR adds one for scikit-learn. The intent is to create a place
to add distributor specific logic, e.g. to implement behavior like in
#14247 (comment)
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?