Skip to content

[MRG] ENH Sets xlabel in plot_partial_dependence only if it is not set before #15610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Resolves #15598 (comment)

What does this implement/fix? Explain your changes.

Only sets xlabel if it was not set before.

Any other comments?

@thomasjpfan thomasjpfan changed the title ENH Sets xlabel only if it is not defined [MRG] ENH Sets xlabel in plot_partial_dependence only if it is not set before Nov 12, 2019
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomasjpfan !

@glemaitre
Copy link
Member

OK make sense.

@glemaitre glemaitre merged commit d85d1e9 into scikit-learn:master Nov 16, 2019
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Nov 18, 2019
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Nov 18, 2019
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_partial_dependence overrides feature names when passing ax
3 participants