Skip to content

MNT Reorder parameters in plot_confusion_matrix #15645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2019
Merged

MNT Reorder parameters in plot_confusion_matrix #15645

merged 3 commits into from
Nov 18, 2019

Conversation

qinhanmin2014
Copy link
Member

Perhaps it's better to put parameters from confusion_matrix together at the beginning.

@qinhanmin2014 qinhanmin2014 added this to the 0.22 milestone Nov 17, 2019
@glemaitre
Copy link
Member

Shall also move sample_weight after labels to have the same order than confusion_matrix exactly?

glemaitre
glemaitre approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre mentioned this pull request Nov 18, 2019
Merged
adrinjalali
adrinjalali approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @qinhanmin2014

@adrinjalali
Copy link
Member

we should also start using keyword only args at some point ;)

@adrinjalali adrinjalali merged commit 816c980 into scikit-learn:master Nov 18, 2019
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Nov 18, 2019
@qinhanmin2014 @adrinjalali
MNT Reorder parameters in plot_confusion_matrix (scikit-learn#15645)
6ab19fe 
* MNT Reorder parameters in plot_confusion_matrix

* MNT Reorder parameters in plot_confusion_matrix

* address comment
adrinjalali pushed a commit that referenced this pull request Nov 19, 2019
@qinhanmin2014 @adrinjalali
MNT Reorder parameters in plot_confusion_matrix (#15645)
d39134b 
* MNT Reorder parameters in plot_confusion_matrix

* MNT Reorder parameters in plot_confusion_matrix

* address comment
@qinhanmin2014 qinhanmin2014 deleted the cm-parameters branch December 6, 2019 04:06
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
@qinhanmin2014
MNT Reorder parameters in plot_confusion_matrix (scikit-learn#15645)
2f9bf48 
* MNT Reorder parameters in plot_confusion_matrix

* MNT Reorder parameters in plot_confusion_matrix

* address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22
Development

Successfully merging this pull request may close these issues.
3 participants
@qinhanmin2014 @glemaitre @adrinjalali