DOC Wrong statement in release highlight #15704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Nov 22, 2019
| # provided in an array with values from 0 to ``n_classes``, and the scores | ||
| # correspond to the probability estimates that a sample belongs to a particular | ||
| # class against all other classes. In both cases, the scores correspond to the | ||
| # probability estimates that a sample belongs to a particular |
There was a problem hiding this comment.
I find the expression "the scores" misleading here because just before we mentioned "the ROC AUC scores". I believe that "the scores" in this sentence are the output of clf.predict_proba(X), not the output of roc_auc_score(y, clf.predict_proba(X), multi_class='ovo').
Maybe this could be rephrased as:
"""
In both cases the multiclass ROC AUC scores are computed from the probability estimates that a sample belongs to a particular class according to the model.
"""
Co-Authored-By: Joel Nothman <joel.nothman@gmail.com>
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 25, 2019
jnothman
pushed a commit
that referenced
this pull request
Nov 28, 2019
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
y_true don't need to be integers between 0 and
n_classes - 1.See https://scikit-learn.org/dev/modules/generated/sklearn.metrics.roc_auc_score.html
labels array, shape = [n_classes] or None, optional (default=None)
List of labels to index y_score used for multiclass. If None, the lexicon order of y_true is used to index y_score
ping @adrinjalali