Skip to content

DOC improve random_state docsting in _ridge and small clean-up #15728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2020
Merged

DOC improve random_state docsting in _ridge and small clean-up #15728

merged 3 commits into from
Jan 8, 2020

Conversation

MDouriez
Copy link
Contributor

@MDouriez MDouriez commented Nov 28, 2019 •
edited
Loading

Reference Issues/PRs

#15222

What does this implement/fix? Explain your changes.

Add link to glossary for random_state

Any other comments?

@MDouriez
Copy link
Contributor Author

MDouriez commented Dec 5, 2019

@NicolasHug Le me know if this seems useful at all, thanks!

NicolasHug
NicolasHug approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as in Same comments as in #15729 about "optional" and saga, but LGTM

Thanks @MDouriez

@rth rth added the Needs work label Dec 6, 2019
@glemaitre glemaitre self-requested a review January 8, 2020 15:13
@glemaitre
Copy link
Member

I will fix up the merge conflict and merge

@glemaitre glemaitre changed the title MNT random_state doc for _ridge + small refactor DOC improve random_state docsting in _ridge and small clean-up Jan 8, 2020
@glemaitre glemaitre merged commit ceed3eb into scikit-learn:master Jan 8, 2020
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
@MDouriez @thomasjpfan
DOC improve random_state docsting in _ridge and small clean-up (sciki…
5b17709 
…t-learn#15728)
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
@MDouriez
DOC improve random_state docsting in _ridge and small clean-up (sciki…
9beac24 
…t-learn#15728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MDouriez @glemaitre @NicolasHug @rth